On 17:52-20210421, Rob Herring wrote: > On Fri, Apr 16, 2021 at 05:25:18PM -0500, Nishanth Menon wrote: > > Convert linaro,optee-tz to json schema format for better documentation > > and error checks. > > > > NOTE: > > 1. This change does introduce a stricter naming convention for > > optee nodes. > > 2. We do have false positive checkpatch warning with this patch: > > "DT binding docs and includes should be a separate patch" > > Not really something that needs to be in the commit msg. I'm aware of > the issue, just haven't gotten around to fixing it. sure, thanks.. In this patch and my previous patches as well, I will move them all to diffstat comment. > > +properties: > > + $nodename: > > + const: 'optee' > > Don't need quotes. aarrgh.. yes, ofcourse. > > > + > > + compatible: > > + const: linaro,optee-tz > > + > > + method: > > + description: The method of calling the OP-TEE Trusted OS. > > + oneOf: > > + - description: | > > + SMC #0, with the register assignments specified > > + in drivers/tee/optee/optee_smc.h > > + items: > > + - const: smc > > + - description: | > > + HVC #0, with the register assignments specified > > + in drivers/tee/optee/optee_smc.h > > + items: > > + - const: hvc > > Please just do 'enum: [ smc, hvc ]' and rework to a single description. Sure, will do. thanks for the comments. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D)/Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
