On Tue, Mar 30, 2021 at 4:29 AM Kishon Vijay Abraham I <kishon@xxxxxx> wrote: > > Hi Rob, > > On 26/03/21 5:08 am, Rob Herring wrote: > > On Thu, Mar 25, 2021 at 02:30:21PM +0530, Kishon Vijay Abraham I wrote: > >> Add PCIe host mode dt-bindings for TI's AM65 SoC. > >> > >> Signed-off-by: Kishon Vijay Abraham I <kishon@xxxxxx> > >> --- > >> .../bindings/pci/ti,am65-pci-host.yaml | 111 ++++++++++++++++++ > >> 1 file changed, 111 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/pci/ti,am65-pci-host.yaml > >> > >> diff --git a/Documentation/devicetree/bindings/pci/ti,am65-pci-host.yaml b/Documentation/devicetree/bindings/pci/ti,am65-pci-host.yaml > >> new file mode 100644 > >> index 000000000000..b77e492886fa > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/pci/ti,am65-pci-host.yaml > >> @@ -0,0 +1,111 @@ > >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > >> +# Copyright (C) 2021 Texas Instruments Incorporated - http://www.ti.com/ > >> +%YAML 1.2 > >> +--- > >> +$id: "http://devicetree.org/schemas/pci/ti,am65-pci-host.yaml#"; > >> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"; > >> + > >> +title: TI AM65 PCI Host > >> + > >> +maintainers: > >> + - Kishon Vijay Abraham I <kishon@xxxxxx> > >> + > >> +allOf: > >> + - $ref: /schemas/pci/pci-bus.yaml# > >> + > >> +properties: > >> + compatible: > >> + enum: > >> + - ti,am654-pcie-rc > >> + > >> + reg: > >> + maxItems: 4 > >> + > >> + reg-names: > >> + items: > >> + - const: app > >> + - const: dbics > > > > Please use 'dbi' like everyone else if this isn't shared with the other > > TI DW PCI bindings. > > I'm just converting existing binding in pci-keystone.txt to yaml. > Documentation/devicetree/bindings/pci/pci-keystone.txt > > Device tree for AM65 is also already in the upstream kernel. > > I can try to remove the am65 specific part from pci-keystone.txt Can you remove pci-keystone.txt entirely. That's what 'converting' means. Rob
