RE: [PATCH 2/2] clk: imx: Remove the audio ipg clock from imx8mp

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> -----Original Message-----
> From: Stephen Boyd [mailto:sboyd@xxxxxxxxxx]
> Sent: Saturday, April 17, 2021 7:57 AM
> To: Jacky Bai <ping.bai@xxxxxxx>; Abel Vesa <abel.vesa@xxxxxxx>;
> robh+dt@xxxxxxxxxx; s.hauer@xxxxxxxxxxxxxx; shawnguo@xxxxxxxxxx
> Cc: festevam@xxxxxxxxx; devicetree@xxxxxxxxxxxxxxx;
> linux-clk@xxxxxxxxxxxxxxx; dl-linux-imx <linux-imx@xxxxxxx>
> Subject: Re: [PATCH 2/2] clk: imx: Remove the audio ipg clock from imx8mp
> 
> Quoting Jacky Bai (2021-04-16 00:37:03)
> > diff --git a/include/dt-bindings/clock/imx8mp-clock.h
> > b/include/dt-bindings/clock/imx8mp-clock.h
> > index 43927a1b9e94..235c7a00d379 100644
> > --- a/include/dt-bindings/clock/imx8mp-clock.h
> > +++ b/include/dt-bindings/clock/imx8mp-clock.h
> > @@ -117,7 +117,6 @@
> >  #define IMX8MP_CLK_AUDIO_AHB                   108
> >  #define IMX8MP_CLK_MIPI_DSI_ESC_RX             109
> >  #define IMX8MP_CLK_IPG_ROOT                    110
> > -#define IMX8MP_CLK_IPG_AUDIO_ROOT              111
> 
> Maybe just add a comment saying it isn't there? Or remove it in three months
> time once DTS no longer references it?
> 

Ok, will resolve this comments in V2. I can add some comments and keep it here for a while.

> Removing this here means that it has to merge whenever the DTS doesn't
> reference it anymore which causes a cross tree dependency.

Right, this delete will lead to the dependency with the dts tree for now.

BR
Jacky Bai

> 
> >  #define IMX8MP_CLK_DRAM_ALT                    112
> >  #define IMX8MP_CLK_DRAM_APB                    113
> >  #define IMX8MP_CLK_VPU_G1                      114




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux