On Fri, Apr 16, 2021 at 01:30:01PM -0500, Rob Herring wrote: > On Fri, 16 Apr 2021 13:49:26 +0200, Michael Walle wrote: > > Flash devices can have one-time-programmable regions. Add a nvmem > > binding so they can be used as a nvmem provider. > > > > Signed-off-by: Michael Walle <michael@xxxxxxxx> > > --- > > Changes since RFC: > > - added missing "$" > > - dropped first example > > - use real device compatibles > > > > Please note, that this will lead to an error without patch 4/5, which > > introduces that property for the jedec,spi-nor. Should I keep it > > seperate or should I squash that patch into this one? > > > > .../devicetree/bindings/mtd/mtd.yaml | 50 +++++++++++++++++++ > > 1 file changed, 50 insertions(+) > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mtd/mtd.example.dt.yaml: flash@0: 'otp-1', 'otp-2' do not match any of the regexes: '^partition@', 'pinctrl-[0-9]+' > From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml Don't worry about this one if the series passes. There's not really a good way to avoid it other than moving the example. Rob
