Re: [PATCH] arm64: boot: dts: qcom: sm8150: add SPI nodes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 15 Apr 2021 at 14:02, Felipe Balbi <balbi@xxxxxxxxxx> wrote:
>
> Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> writes:
>
> > On Thu, 15 Apr 2021 at 13:39, Felipe Balbi <balbi@xxxxxxxxxx> wrote:
> >>
> >> From: Felipe Balbi <felipe.balbi@xxxxxxxxxxxxx>
> >>
> >> Add missing SPI nodes for SM8150.
> >>
> >> Signed-off-by: Felipe Balbi <felipe.balbi@xxxxxxxxxxxxx>
> >
> > I'd suggest switching to gpio-cs as implemented for sc7180 and sm8250.
> > At least I'd propose to split the pinctrl into data+clock and CS
> > configurations, so that the CS implementation can be easily selected
> > on the board level.
>
> I can do that, sure. What do we gain from it, though? The possibility of
> using more chip selects? It also sounds to me like this could be done as
> a separate patch.

I'd refer to the original discussion for sc7180:
https://lore.kernel.org/linux-arm-msm/20200624170746.1.I997a428f58ef9d48b37a27a028360f34e66c00ec@changeid/

-- 
With best wishes
Dmitry



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux