> Il giorno 13 apr 2021, alle ore 19:58, Rob Herring <robh@xxxxxxxxxx> ha scritto: > > On Tue, Apr 13, 2021 at 10:27 AM Giulio Benetti > <giulio.benetti@xxxxxxxxxxxxxxxxxxxxxx> wrote: >> >>> On 4/13/21 5:07 PM, Rob Herring wrote: >>> On Mon, 12 Apr 2021 17:23:59 +0200, Giulio Benetti wrote: >>>> This adds device tree bindings for the Hycon HY46XX touchscreen series. >>>> >>>> Signed-off-by: Giulio Benetti <giulio.benetti@xxxxxxxxxxxxxxxxxxxxxx> >>>> --- >>>> V1->V2: >>>> As suggested by Rob Herring: >>>> * fixed $id: address >>>> * added "hycon," in front of every custom property >>>> * changed all possible property to boolean type >>>> * removed proximity-sensor-switch property since it's not handled in driver >>>> V2->V3: >>>> As suggested by Jonathan Neuschäfer: >>>> * fixed some typo >>>> * fixed description indentation >>>> * improved boolean properties descriptions >>>> * improved hycon,report-speed description >>>> V3->V4: >>>> * fixed binding compatible string in example as suggested by Jonathan Neuschäfer >>>> V4->V5: >>>> As suggested by Rob Herring: >>>> * drop hycon- prefix from compatible >>>> * use Hertz unit suffix for hycon,report-speed instead of u32 >>>> * set hycon,report-speed minimum to 1Hz, 0Hz make controller to do nothing >>>> * change hycon,power-noise-enable property name to hycon,noise-filter-enable >>>> * improve hycon,filter-data property description >>>> * use generic touchscreen node name in example >>>> V5->V6: >>>> * changed report-speed property name into report-speed-hz according to >>>> Rob Herring's suggestion >>>> --- >>>> .../input/touchscreen/hycon,hy46xx.yaml | 119 ++++++++++++++++++ >>>> MAINTAINERS | 6 + >>>> 2 files changed, 125 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/input/touchscreen/hycon,hy46xx.yaml >>>> >>> >>> Reviewed-by: Rob Herring <robh@xxxxxxxxxx> >> >> I've sent v7[1] before receiving your Reviewed-by. >> Do I have to re-submit it once and if I receive a Reviewed-by from you >> as a v8 with all your Reviewed-by's? > > I gave it on v7 too, so only if there are other changes on any of the > patches. Ah ok, thank you. > The tools will generally pick up any tags on the version > applied. You just can't expect maintainers to go rummage thru old > versions to find any tags. Sure not, this is the reason why I’ve asked, I’ve forgotten to add some tag to my commits that I usually do, that’s why I’ve messed things up. Thank you again for reviewing and explaining me. Best regards Giulio Benetti > > Rob
