On 12/04/2021 18:20, Jassi Brar wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> On Mon, Apr 12, 2021 at 11:04 AM <conor.dooley@xxxxxxxxxxxxx> wrote:
>
>> diff --git a/drivers/mailbox/mailbox-mpfs.c b/drivers/mailbox/mailbox-mpfs.c
>> + return (struct mpfs_mbox *)chan->con_priv;
>> +}
>> +
>> +static int mpfs_mbox_send_data(struct mbox_chan *chan, void *data)
>> +{
>> + u32 val = 0u;
>> + u16 opt_sel;
>> + u32 tx_trigger;
>> + struct mpfs_mss_msg *msg = data;
>> + struct mpfs_mbox *mbox = mbox_chan_to_mpfs_mbox(chan);
>> +
>> + mbox->response = msg->response;
>> + mbox->resp_offset = msg->resp_offset;
>> +
>> + if (mpfs_mbox_busy(mbox))
>> + return -EBUSY;
>> +
> This check should be unnecessary because the api won't call
> send_data() unless the last one is done.
>
>
will act on the other observations/requests, this one should stay as is
though - possible for something other than this driver to cause the
system controller to be busy.
cheers
