Hi, Rob, In mt8192 hardware, we only control top power domain in kernel. It is unnecessary to create a specific header just for such purpose. I will update the patch in the next version. Thanks for your review. Thanks, Flora On Fri, 2021-04-09 at 13:23 -0500, Rob Herring wrote: > On Wed, Apr 07, 2021 at 11:28:01AM +0800, Flora Fu wrote: > > Create MT8192 APU power domain bindings. > > Add top power domain id. > > > > Signed-off-by: Flora Fu <flora.fu@xxxxxxxxxxxx> > > --- > > include/dt-bindings/power/mt8192-apu-power.h | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > create mode 100644 include/dt-bindings/power/mt8192-apu-power.h > > > > diff --git a/include/dt-bindings/power/mt8192-apu-power.h b/include/dt-bindings/power/mt8192-apu-power.h > > new file mode 100644 > > index 000000000000..b821bd4811a6 > > --- /dev/null > > +++ b/include/dt-bindings/power/mt8192-apu-power.h > > @@ -0,0 +1,11 @@ > > +/* SPDX-License-Identifier: GPL-2.0 > > + * > > + * Copyright (c) 2021 MediaTek Inc. > > + */ > > + > > +#ifndef _DT_BINDINGS_POWER_MT8192_APU_POWER_H > > +#define _DT_BINDINGS_POWER_MT8192_APU_POWER_H > > + > > +#define MT8192_POWER_DOMAIN_APUSYS_TOP 0 > > Really, you don't know what the other power domains are? Please make > this as complete as possible. These headers create a merge mess. > > Rob
