Re: [PATCH v4 08/11] pinctrl: Ingenic: Add pinctrl driver for JZ4750.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi "周琰杰,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on pinctrl/devel]
[also build test ERROR on robh/for-next linus/master v5.12-rc6 next-20210409]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Zhou-Yanjie/Fix-bugs-and-add-support-for-new-Ingenic-SoCs/20210411-025656
base:   https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/76f684ad7bcc8b973c1a622beb0c12cf13e7ba10
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Zhou-Yanjie/Fix-bugs-and-add-support-for-new-Ingenic-SoCs/20210411-025656
        git checkout 76f684ad7bcc8b973c1a622beb0c12cf13e7ba10
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sh 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

Note: the linux-review/Zhou-Yanjie/Fix-bugs-and-add-support-for-new-Ingenic-SoCs/20210411-025656 HEAD f620590a49d7d82d9e111928ccb3d435768a62e4 builds fine.
      It only hurts bisectibility.

All error/warnings (new ones prefixed by >>):

>> drivers/pinctrl/pinctrl-ingenic.c:2882:3: error: field name not in record or union initializer
    2882 |   .compatible = "ingenic,jz4760-pinctrl",
         |   ^
   drivers/pinctrl/pinctrl-ingenic.c:2882:3: note: (near initialization for 'ingenic_pinctrl_of_match')
   drivers/pinctrl/pinctrl-ingenic.c:2883:3: error: field name not in record or union initializer
    2883 |   .data = IF_ENABLED(CONFIG_MACH_JZ4760, &jz4760_chip_info)
         |   ^
   drivers/pinctrl/pinctrl-ingenic.c:2883:3: note: (near initialization for 'ingenic_pinctrl_of_match')
   In file included from <command-line>:
>> include/linux/kconfig.h:79:33: warning: initialization of 'char' from 'const struct ingenic_chip_info *' makes integer from pointer without a cast [-Wint-conversion]
      79 | #define IF_ENABLED(option, ptr) (IS_ENABLED(option) ? (ptr) : NULL)
         |                                 ^
   drivers/pinctrl/pinctrl-ingenic.c:2883:11: note: in expansion of macro 'IF_ENABLED'
    2883 |   .data = IF_ENABLED(CONFIG_MACH_JZ4760, &jz4760_chip_info)
         |           ^~~~~~~~~~
   include/linux/kconfig.h:79:33: note: (near initialization for 'ingenic_pinctrl_of_match[5].name[0]')
      79 | #define IF_ENABLED(option, ptr) (IS_ENABLED(option) ? (ptr) : NULL)
         |                                 ^
   drivers/pinctrl/pinctrl-ingenic.c:2883:11: note: in expansion of macro 'IF_ENABLED'
    2883 |   .data = IF_ENABLED(CONFIG_MACH_JZ4760, &jz4760_chip_info)
         |           ^~~~~~~~~~
>> drivers/pinctrl/pinctrl-ingenic.c:2865:63: warning: missing braces around initializer [-Wmissing-braces]
    2865 | static const struct of_device_id ingenic_pinctrl_of_match[] = {
         |                                                               ^
>> drivers/pinctrl/pinctrl-ingenic.c:2885:2: error: expected identifier or '(' before '{' token
    2885 |  {
         |  ^
   drivers/pinctrl/pinctrl-ingenic.c:2888:3: error: expected identifier or '(' before ',' token
    2888 |  },
         |   ^
   drivers/pinctrl/pinctrl-ingenic.c:2892:3: error: expected identifier or '(' before ',' token
    2892 |  },
         |   ^
   drivers/pinctrl/pinctrl-ingenic.c:2896:3: error: expected identifier or '(' before ',' token
    2896 |  },
         |   ^
   drivers/pinctrl/pinctrl-ingenic.c:2900:3: error: expected identifier or '(' before ',' token
    2900 |  },
         |   ^
   drivers/pinctrl/pinctrl-ingenic.c:2904:3: error: expected identifier or '(' before ',' token
    2904 |  },
         |   ^
   drivers/pinctrl/pinctrl-ingenic.c:2908:3: error: expected identifier or '(' before ',' token
    2908 |  },
         |   ^
   drivers/pinctrl/pinctrl-ingenic.c:2912:3: error: expected identifier or '(' before ',' token
    2912 |  },
         |   ^
   drivers/pinctrl/pinctrl-ingenic.c:2913:20: error: expected identifier or '(' before ',' token
    2913 |  { /* sentinel */ },
         |                    ^
   drivers/pinctrl/pinctrl-ingenic.c:1901:39: warning: 'x1830_chip_info' defined but not used [-Wunused-const-variable=]
    1901 | static const struct ingenic_chip_info x1830_chip_info = {
         |                                       ^~~~~~~~~~~~~~~
   drivers/pinctrl/pinctrl-ingenic.c:1695:39: warning: 'x1500_chip_info' defined but not used [-Wunused-const-variable=]
    1695 | static const struct ingenic_chip_info x1500_chip_info = {
         |                                       ^~~~~~~~~~~~~~~
   drivers/pinctrl/pinctrl-ingenic.c:1592:39: warning: 'x1000_chip_info' defined but not used [-Wunused-const-variable=]
    1592 | static const struct ingenic_chip_info x1000_chip_info = {
         |                                       ^~~~~~~~~~~~~~~
   drivers/pinctrl/pinctrl-ingenic.c:1379:39: warning: 'jz4780_chip_info' defined but not used [-Wunused-const-variable=]
    1379 | static const struct ingenic_chip_info jz4780_chip_info = {
         |                                       ^~~~~~~~~~~~~~~~
   drivers/pinctrl/pinctrl-ingenic.c:1119:39: warning: 'jz4770_chip_info' defined but not used [-Wunused-const-variable=]
    1119 | static const struct ingenic_chip_info jz4770_chip_info = {
         |                                       ^~~~~~~~~~~~~~~~

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for SND_ATMEL_SOC_PDC
   Depends on SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC && HAS_DMA
   Selected by
   - SND_ATMEL_SOC_SSC && SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC
   - SND_ATMEL_SOC_SSC_PDC && SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC && ATMEL_SSC


vim +2882 drivers/pinctrl/pinctrl-ingenic.c

b5c23aa4653796 Paul Cercueil        2017-05-12  2864  
baf15647387e82 Paul Cercueil        2020-01-07 @2865  static const struct of_device_id ingenic_pinctrl_of_match[] = {
c6de2661f69f58 周琰杰 (Zhou Yanjie  2021-04-11  2866) 	{
c6de2661f69f58 周琰杰 (Zhou Yanjie  2021-04-11  2867) 		.compatible = "ingenic,jz4730-pinctrl",
c6de2661f69f58 周琰杰 (Zhou Yanjie  2021-04-11  2868) 		.data = IF_ENABLED(CONFIG_MACH_JZ4730, &jz4730_chip_info)
c6de2661f69f58 周琰杰 (Zhou Yanjie  2021-04-11  2869) 	},
9aa351784e6962 Paul Cercueil        2020-12-13  2870  	{
9aa351784e6962 Paul Cercueil        2020-12-13  2871  		.compatible = "ingenic,jz4740-pinctrl",
9aa351784e6962 Paul Cercueil        2020-12-13  2872  		.data = IF_ENABLED(CONFIG_MACH_JZ4740, &jz4740_chip_info)
9aa351784e6962 Paul Cercueil        2020-12-13  2873  	},
9aa351784e6962 Paul Cercueil        2020-12-13  2874  	{
9aa351784e6962 Paul Cercueil        2020-12-13  2875  		.compatible = "ingenic,jz4725b-pinctrl",
9aa351784e6962 Paul Cercueil        2020-12-13  2876  		.data = IF_ENABLED(CONFIG_MACH_JZ4725B, &jz4725b_chip_info)
9aa351784e6962 Paul Cercueil        2020-12-13  2877  	},
9aa351784e6962 Paul Cercueil        2020-12-13  2878  	{
76f684ad7bcc8b 周琰杰 (Zhou Yanjie  2021-04-11  2879) 		.compatible = "ingenic,jz4750-pinctrl",
76f684ad7bcc8b 周琰杰 (Zhou Yanjie  2021-04-11  2880) 		.data = IF_ENABLED(CONFIG_MACH_JZ4750, &jz4750_chip_info)
76f684ad7bcc8b 周琰杰 (Zhou Yanjie  2021-04-11  2881) 	},
9aa351784e6962 Paul Cercueil        2020-12-13 @2882  		.compatible = "ingenic,jz4760-pinctrl",
9aa351784e6962 Paul Cercueil        2020-12-13 @2883  		.data = IF_ENABLED(CONFIG_MACH_JZ4760, &jz4760_chip_info)
9aa351784e6962 Paul Cercueil        2020-12-13  2884  	},
9aa351784e6962 Paul Cercueil        2020-12-13 @2885  	{
9aa351784e6962 Paul Cercueil        2020-12-13  2886  		.compatible = "ingenic,jz4760b-pinctrl",
9aa351784e6962 Paul Cercueil        2020-12-13  2887  		.data = IF_ENABLED(CONFIG_MACH_JZ4760, &jz4760_chip_info)
9aa351784e6962 Paul Cercueil        2020-12-13  2888  	},
9aa351784e6962 Paul Cercueil        2020-12-13  2889  	{
9aa351784e6962 Paul Cercueil        2020-12-13  2890  		.compatible = "ingenic,jz4770-pinctrl",
9aa351784e6962 Paul Cercueil        2020-12-13  2891  		.data = IF_ENABLED(CONFIG_MACH_JZ4770, &jz4770_chip_info)
9aa351784e6962 Paul Cercueil        2020-12-13  2892  	},
9aa351784e6962 Paul Cercueil        2020-12-13  2893  	{
9aa351784e6962 Paul Cercueil        2020-12-13  2894  		.compatible = "ingenic,jz4780-pinctrl",
9aa351784e6962 Paul Cercueil        2020-12-13  2895  		.data = IF_ENABLED(CONFIG_MACH_JZ4780, &jz4780_chip_info)
9aa351784e6962 Paul Cercueil        2020-12-13  2896  	},
9aa351784e6962 Paul Cercueil        2020-12-13  2897  	{
9aa351784e6962 Paul Cercueil        2020-12-13  2898  		.compatible = "ingenic,x1000-pinctrl",
9aa351784e6962 Paul Cercueil        2020-12-13  2899  		.data = IF_ENABLED(CONFIG_MACH_X1000, &x1000_chip_info)
9aa351784e6962 Paul Cercueil        2020-12-13  2900  	},
9aa351784e6962 Paul Cercueil        2020-12-13  2901  	{
9aa351784e6962 Paul Cercueil        2020-12-13  2902  		.compatible = "ingenic,x1000e-pinctrl",
9aa351784e6962 Paul Cercueil        2020-12-13  2903  		.data = IF_ENABLED(CONFIG_MACH_X1000, &x1000_chip_info)
9aa351784e6962 Paul Cercueil        2020-12-13  2904  	},
9aa351784e6962 Paul Cercueil        2020-12-13  2905  	{
9aa351784e6962 Paul Cercueil        2020-12-13  2906  		.compatible = "ingenic,x1500-pinctrl",
9aa351784e6962 Paul Cercueil        2020-12-13  2907  		.data = IF_ENABLED(CONFIG_MACH_X1500, &x1500_chip_info)
9aa351784e6962 Paul Cercueil        2020-12-13  2908  	},
9aa351784e6962 Paul Cercueil        2020-12-13  2909  	{
9aa351784e6962 Paul Cercueil        2020-12-13  2910  		.compatible = "ingenic,x1830-pinctrl",
9aa351784e6962 Paul Cercueil        2020-12-13  2911  		.data = IF_ENABLED(CONFIG_MACH_X1830, &x1830_chip_info)
9aa351784e6962 Paul Cercueil        2020-12-13  2912  	},
9aa351784e6962 Paul Cercueil        2020-12-13  2913  	{ /* sentinel */ },
baf15647387e82 Paul Cercueil        2020-01-07  2914  };
baf15647387e82 Paul Cercueil        2020-01-07  2915  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux