On Fri, Apr 9, 2021 at 4:07 AM Joakim Zhang <qiangqing.zhang@xxxxxxx> wrote: > > From: Fugang Duan <fugang.duan@xxxxxxx> > > Currently, of_get_mac_address supports NVMEM, some platforms What's of_get_mac_address? This is a binding patch. Don't mix Linux things in it. > MAC address that read from NVMEM efuse requires to swap bytes > order, so add new property "nvmem_macaddr_swap" to specify the > behavior. If the MAC address is valid from NVMEM, add new property > "nvmem-mac-address" in ethernet node. > > Update these two properties in the binding documentation. > > Signed-off-by: Fugang Duan <fugang.duan@xxxxxxx> > Signed-off-by: Joakim Zhang <qiangqing.zhang@xxxxxxx> > --- > .../bindings/net/ethernet-controller.yaml | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/ethernet-controller.yaml b/Documentation/devicetree/bindings/net/ethernet-controller.yaml > index e8f04687a3e0..c868c295aabf 100644 > --- a/Documentation/devicetree/bindings/net/ethernet-controller.yaml > +++ b/Documentation/devicetree/bindings/net/ethernet-controller.yaml > @@ -32,6 +32,15 @@ properties: > - minItems: 6 > maxItems: 6 > > + nvmem-mac-address: > + allOf: > + - $ref: /schemas/types.yaml#definitions/uint8-array > + - minItems: 6 > + maxItems: 6 > + description: > + Specifies the MAC address that was read from nvmem-cells and dynamically > + add the property in device node; Why can't you use local-mac-address or mac-address? Those too can come from some other source. > + > max-frame-size: > $ref: /schemas/types.yaml#/definitions/uint32 > description: > @@ -52,6 +61,11 @@ properties: > nvmem-cell-names: > const: mac-address > > + nvmem_macaddr_swap: > + $ref: /schemas/types.yaml#/definitions/flag > + description: > + swap bytes order for the 6 bytes of MAC address So 'nvmem-mac-address' needs to be swapped or it's swapped before writing? In any case, this belongs in the nvmem provider. Rob