On 4/8/21 3:53 PM, Frank Rowand wrote: > On 4/8/21 4:54 PM, Guenter Roeck wrote: >> On 4/8/21 2:28 PM, Rob Herring wrote: >>> >>> Applying now so this gets into linux-next this week. >>> >> The patch doesn't apply on top of today's -next; it conflicts >> with "of: properly check for error returned by fdt_get_name()". >> >> I reverted that patch and applied this one, and the DT unittests >> run with it on openrisc. I do get a single test failure, but I that >> is a different problem (possibly with the test case itself). >> >> ### dt-test ### FAIL of_unittest_dma_ranges_one():923 of_dma_get_range: wrong DMA addr 0x00000000 >> (expecting 100000000) on node /testcase-data/address-tests/bus@80000000/device@1000 > > That is a known regression on the target that I use for testing (and > has been since 5.10-rc1) - the 8074 dragonboard, arm 32. No > one else has reported it on the list, so even though I want to debug > and fix it "promptly", other tasks have had higher priority. In my > notes I list two suspect commits: > > e0d072782c73 dma-mapping: introduce DMA range map, supplanting dma_pfn_offset > 0a0f0d8be76d dma-mapping: split <linux/dma-mapping.h> > > I think that was purely based on looking at the list of commits that > may have touched OF dma. I have not done a bisect. > Here you are: # bad: [2c85ebc57b3e1817b6ce1a6b703928e113a90442] Linux 5.10 # good: [bbf5c979011a099af5dc76498918ed7df445635b] Linux 5.9 git bisect start 'v5.10' 'v5.9' # bad: [4d0e9df5e43dba52d38b251e3b909df8fa1110be] lib, uaccess: add failure injection to usercopy functions git bisect bad 4d0e9df5e43dba52d38b251e3b909df8fa1110be # good: [f888bdf9823c85fe945c4eb3ba353f749dec3856] Merge tag 'devicetree-for-5.10' of git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux git bisect good f888bdf9823c85fe945c4eb3ba353f749dec3856 # good: [640eee067d9aae0bb98d8706001976ff1affaf00] Merge tag 'drm-misc-next-fixes-2020-10-13' of git://anongit.freedesktop.org/drm/drm-misc into drm-next git bisect good 640eee067d9aae0bb98d8706001976ff1affaf00 # good: [c6dbef7307629cce855aa6b482b60cbf7777ed88] Merge tag 'usb-5.10-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb git bisect good c6dbef7307629cce855aa6b482b60cbf7777ed88 # good: [ce1558c285f9ad04c03b46833a028230771cc0a7] ALSA: hda/hdmi: fix incorrect locking in hdmi_pcm_close git bisect good ce1558c285f9ad04c03b46833a028230771cc0a7 # good: [c48b75b7271db23c1b2d1204d6e8496d91f27711] Merge tag 'sound-5.10-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound git bisect good c48b75b7271db23c1b2d1204d6e8496d91f27711 # bad: [0cd7d9795fa82226e7516d38b474bddae8b1ff26] Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/livepatching/livepatching git bisect bad 0cd7d9795fa82226e7516d38b474bddae8b1ff26 # good: [b1839e7c2a42ccd9a0587c0092e880c7a213ee2a] dmaengine: xilinx: dpdma: convert tasklets to use new tasklet_setup() API git bisect good b1839e7c2a42ccd9a0587c0092e880c7a213ee2a # bad: [0de327969b61a245e3a47b60009eae73fe513cef] cma: decrease CMA_ALIGNMENT lower limit to 2 git bisect bad 0de327969b61a245e3a47b60009eae73fe513cef # good: [6eb0233ec2d0df288fe8515d5b0b2b15562e05bb] usb: don't inherity DMA properties for USB devices git bisect good 6eb0233ec2d0df288fe8515d5b0b2b15562e05bb # bad: [48d15814dd0fc429e3205b87f1af6cc472018478] lib82596: move DMA allocation into the callers of i82596_probe git bisect bad 48d15814dd0fc429e3205b87f1af6cc472018478 # bad: [eba304c6861613a649ba46cfab835b1eddeacd8e] dma-mapping: better document dma_addr_t and DMA_MAPPING_ERROR git bisect bad eba304c6861613a649ba46cfab835b1eddeacd8e # bad: [b9bb694b9f62f4b31652223ed3ca38cf98bbb370] iommu/io-pgtable-arm: Clean up faulty sanity check git bisect bad b9bb694b9f62f4b31652223ed3ca38cf98bbb370 # bad: [a97740f81874c8063c12c24f34d25f10c4f5e9aa] dma-debug: convert comma to semicolon git bisect bad a97740f81874c8063c12c24f34d25f10c4f5e9aa # bad: [e0d072782c734d27f5af062c62266f2598f68542] dma-mapping: introduce DMA range map, supplanting dma_pfn_offset git bisect bad e0d072782c734d27f5af062c62266f2598f68542 # first bad commit: [e0d072782c734d27f5af062c62266f2598f68542] dma-mapping: introduce DMA range map, supplanting dma_pfn_offset Guenter