Re: [PATCH] clk: fix for_each_child.cocci warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Julia Lawall (2021-04-07 12:02:32)
> From: kernel test robot <lkp@xxxxxxxxx>
> 
> For_each_child_of_node should have of_node_put() before goto.
> 
> Generated by: scripts/coccinelle/iterators/for_each_child.cocci
> 
> CC: Liam Beguin <lvb@xxxxxxxxxx>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Signed-off-by: kernel test robot <lkp@xxxxxxxxx>
> Signed-off-by: Julia Lawall <julia.lawall@xxxxxxxx>
> ---

Is this a fix for a patch on the list?

> 
> url:    https://github.com/0day-ci/linux/commits/Liam-Beguin/add-support-for-the-lmk04832/20210407-085408
> base:   f40ddce88593482919761f74910f42f4b84c004b
> :::::: branch date: 9 hours ago
> :::::: commit date: 9 hours ago
> 
>  clk-lmk04832.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- a/drivers/clk/clk-lmk04832.c
> +++ b/drivers/clk/clk-lmk04832.c
> @@ -1159,6 +1159,7 @@ static int lmk04832_probe(struct spi_dev
>                 if (ret) {
>                         dev_err(lmk->dev, "missing reg property in child: %s\n",
>                                 child->full_name);
> +                       of_node_put(child);
>                         goto err_disable_oscin;
>                 }
>




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux