Hi Arnd,
On 07/04/2021 18:06, Arnd Bergmann wrote:
> On Wed, Apr 7, 2021 at 1:00 PM Matthias Brugger <matthias.bgg@xxxxxxxxx> wrote:
>>
>> Hi Olof and Arnd,
>>
>> Here comes the second round of arm64 DT patches. Hope I'm not too late.
>> Basically we add several node to MT8167.
>> ----------------------------------------------------------------
>> Fabien Parent (6):
>
>> arm64: dts: mediatek: mt8167: add some DRM nodes
>
> I stumbled over this patch adding a lot of aliases:
>
> + aliases {
> + aal0 = &aal;
> + ccorr0 = &ccorr;
> + color0 = &color;
> + dither0 = &dither;
> + dsi0 = &dsi;
> + ovl0 = &ovl0;
> + pwm0 = &disp_pwm;
> + rdma0 = &rdma0;
> + rdma1 = &rdma1;
> + wdma0 = &wdma;
> + };
>
>
> Something doesn't quite feel right about this, and I checked with Rob,
> who also thinks this looks wrong. I suppose we need to have a set of
> well documented alias types rather than just having drivers make up
> new ones on the spot.
These are needed in the DRM driver, see drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c
I added Chun-Kuang who is the maintainer of the driver. I think it's a good idea
to have this alias described in the binding. Maybe a good excuse to move to yaml
as well :)
>
> I also noticed that some of the referenced nodes are missing a DT
> binding file, so those need to be added and reviewed as well.
I suppose you are talking about "mediatek,mt8173-vcodec-enc-vp8". The binding
patches are in the media tree [1]. Maybe I supposed wrongly that they will land
in v5.13? Or perhaps I should have mentioned that in the pull request.
If it wasn't about this compatible and you can still remember, please let me
know so that we can fix that :)
I double checked and didn't find any missing binding. Some of them only have the
fallback binding described, maybe that's what you are referring to.
>
> At this point, I'd prefer to drop the entire branch for v5.13 and have
> you work it out for the next release.
>
Fair enough, pull request was quite late. I'll queue them for the next round then.
Thanks for having a look,
Matthias
[1]
https://git.linuxtv.org/media_tree.git/commit/?id=dd0008beef0dda915a255691e8b3b0527efaf1d8
