On Fri, Jul 11, 2014 at 11:18 AM, Ezequiel Garcia <ezequiel@xxxxxxxxxxxxxxxxxxxx> wrote: > In order to support the "enable GPIO" available in many panel devices, > this commit adds a proper devicetree binding. > > By providing an enable GPIO in the devicetree, the driver can now turn > off and on the panel device, and/or the backlight device. Both the > backlight and the GPIO are optional properties. > + panel_mod->enable_gpio = devm_gpiod_get(&pdev->dev, "enable"); > + if (IS_ERR(panel_mod->enable_gpio)) { > + ret = PTR_ERR(panel_mod->enable_gpio); > + if (ret != -ENOENT) { Shouldn't this be controlled by a regulator instead? What if the panel is powered from a PMIC output? -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html