On 01/04/2021 08:38, Nina Wu wrote: > From: Nina Wu <Nina-CM.Wu@xxxxxxxxxxxx> > > Add compatible to support mt8192. > > Signed-off-by: Nina Wu <Nina-CM.Wu@xxxxxxxxxxxx> > --- Looks good, I'd like to see DTS for this as well, although I understand it depends on the clock patch series. Please note so in either below the '---' or in a cover letter. Regards, Matthias > drivers/soc/mediatek/mtk-devapc.c | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/drivers/soc/mediatek/mtk-devapc.c b/drivers/soc/mediatek/mtk-devapc.c > index af55c01..a5c15b5 100644 > --- a/drivers/soc/mediatek/mtk-devapc.c > +++ b/drivers/soc/mediatek/mtk-devapc.c > @@ -251,11 +251,26 @@ static const struct mtk_devapc_data devapc_mt6779 = { > .vio_shift_con_offset = 0xF20, > }; > > +static const struct mtk_devapc_data devapc_mt8192 = { > + .vio_mask_offset = 0x0, > + .vio_sta_offset = 0x400, > + .vio_dbg0_offset = 0x900, > + .vio_dbg1_offset = 0x904, > + .vio_dbg2_offset = 0x908, > + .apc_con_offset = 0xF00, > + .vio_shift_sta_offset = 0xF20, > + .vio_shift_sel_offset = 0xF30, > + .vio_shift_con_offset = 0xF10, > +}; > + > static const struct of_device_id mtk_devapc_dt_match[] = { > { > .compatible = "mediatek,mt6779-devapc", > .data = &devapc_mt6779, > }, { > + .compatible = "mediatek,mt8192-devapc", > + .data = &devapc_mt8192, > + }, { > }, > }; > >