On Sat, Mar 27, 2021 at 12:13, Rob Herring <robh@xxxxxxxxxx> wrote: > On Fri, Mar 26, 2021 at 11:56:48AM +0100, Tobias Waldekranz wrote: >> The 'dsa,tag-protocol' is used to force a switch tree to use a >> particular tag protocol, typically because the Ethernet controller >> that it is connected to is not compatible with the default one. >> >> Signed-off-by: Tobias Waldekranz <tobias@xxxxxxxxxxxxxx> >> --- >> Documentation/devicetree/bindings/net/dsa/dsa.yaml | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/net/dsa/dsa.yaml b/Documentation/devicetree/bindings/net/dsa/dsa.yaml >> index 8a3494db4d8d..5dcfab049aa2 100644 >> --- a/Documentation/devicetree/bindings/net/dsa/dsa.yaml >> +++ b/Documentation/devicetree/bindings/net/dsa/dsa.yaml >> @@ -70,6 +70,13 @@ patternProperties: >> device is what the switch port is connected to >> $ref: /schemas/types.yaml#/definitions/phandle >> >> + dsa,tag-protocol: > > 'dsa' is not a vendor. It is not. The property is intended to be consumed by the vendor-independent driver. So should it be linux,tag-protocol? Just tag-protocol? >> + description: >> + Instead of the default, the switch will use this tag protocol if >> + possible. Useful when a device supports multiple protcols and >> + the default is incompatible with the Ethernet device. >> + $ref: /schemas/types.yaml#/definitions/string > > You need to define the possible strings. Alright. Andrew, Vladimir: I will just list dsa and edsa for now. If it is needed on other devices, people can add them to the list after they have tested their drivers. Fair? >> + >> phy-handle: true >> >> phy-mode: true >> -- >> 2.25.1 >>
