On Fri, Mar 26, 2021 at 07:52:07PM +0100, Jonathan Neuschäfer wrote: > On Wed, Mar 24, 2021 at 05:16:35PM +0000, Marc Zyngier wrote: > > On Sat, 20 Mar 2021 18:16:04 +0000, Jonathan Neuschäfer <j.neuschaefer@xxxxxxx> wrote: [...] > > > + /* Disable (mask) all interrupts */ > > > + writel(0xffffffff, aic->regs + AIC_MDCR); > > > > Consider using relaxed accessors throughout this driver. > > I'll read up on how to use them correctly. Upon further consideration, I decided not to bother with relaxed MMIO access, because it doesn't make a difference on the target platform — Nuvoton WPCM450 with ARM926 (ARMv5). Best regards, Jonathan Neuschäfer
Attachment:
signature.asc
Description: PGP signature
