On 21-04-02 19:48:41, Adrien Grassein wrote: > Hi, > > Le ven. 2 avr. 2021 à 19:42, Abel Vesa <abel.vesa@xxxxxxx> a écrit : > > > > On 21-04-02 18:45:04, Adrien Grassein wrote: > > > Hi, > > > > > > this patch et aims to add the support of the i.MX 8 Power Domain driver. > > > Some devices (like usbotg2) can't work without this patch as their > > > attached power domain are down. > > > > > > The original drivr was taken from le imx kernel and aapted to fit with > > > the actual mainline (minor fixes). > > > > > > Thanks, > > > > > > > Big NACK for the whole series. > > > > This approach has already been rejected upstream. > > So what is the correct approach? > At this point otg2 node of imx8mm is not working at all (and blocks the whole > boot of the kernel) > Have a look at this thread: https://lkml.org/lkml/2020/4/27/706 > > > > Plus, you changed the original author, this work was originally done by Jacky Bai. > > I have not changed this, the original author is not mentioned on the > original patch. Here is the original commit: https://github.com/Freescale/linux-fslc/commit/7ebcf5ccf423afe4ccd9c53ef204018b0b653ce0 > > > > > > Adrien Grassein (2): > > > dt-bindings: power: Add documentation for imx8m power domain driver > > > soc: imx: add Power Domain driver for i.MX8M(M|N|P) > > > > > > .../bindings/power/fsl,imx-power-domain.yaml | 89 +++++++ > > > MAINTAINERS | 10 + > > > drivers/soc/imx/Kconfig | 7 + > > > drivers/soc/imx/Makefile | 1 + > > > drivers/soc/imx/imx8m_pm_domains.c | 233 ++++++++++++++++++ > > > include/dt-bindings/power/imx8mm-power.h | 21 ++ > > > include/dt-bindings/power/imx8mn-power.h | 15 ++ > > > include/dt-bindings/power/imx8mp-power.h | 28 +++ > > > include/soc/imx/imx_sip.h | 12 + > > > 9 files changed, 416 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/power/fsl,imx-power-domain.yaml > > > create mode 100644 drivers/soc/imx/imx8m_pm_domains.c > > > create mode 100644 include/dt-bindings/power/imx8mm-power.h > > > create mode 100644 include/dt-bindings/power/imx8mn-power.h > > > create mode 100644 include/dt-bindings/power/imx8mp-power.h > > > create mode 100644 include/soc/imx/imx_sip.h > > > > > > -- > > > 2.25.1 > > > > > Thanks,
