On 07/11/2014 04:10 PM, Sylwester Nawrocki wrote: > Hi Tushar, > > On 11/07/14 11:37, Tushar Behera wrote: >> Change exynos-audss clock driver as per existing clock framework from >> the existing module driver framework. > > Can you explain what's the actual issue you're trying to solve with that > patch ? What's the problem with this driver being a platform driver ? > It feels we're moving in circles here, see > > commit b37a4224104568198b93fb9831224cfe7d83fff8 > Author: Andrew Bresticker <abrestic@xxxxxxxxxxxx> > Date: Wed Sep 25 14:12:47 2013 -0700 > > clk: exynos-audss: convert to platform device > > The Exynos AudioSS clock controller will later be modified to allow > input clocks to be specified via device-tree in order to support > multiple Exynos SoCs. This will introduce a dependency on the core > SoC clock controller being initialized first so that the AudioSS driver > can look up its input clocks, but the order in which clock providers > are probed in of_clk_init() is not guaranteed. Since deferred probing > is not supported in of_clk_init() and the AudioSS block is not the core > controller, we can initialize it later as a platform device. > > Signed-off-by: Andrew Bresticker <abrestic@xxxxxxxxxxxx> > Acked-by: Tomasz Figa <t.figa@xxxxxxxxxxx> > Reviewed-by: Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx> > Acked-by: Mike Turquette <mturquette@xxxxxxxxxx> > Acked-by: Kukjin Kim <kgene.kim@xxxxxxxxxxx> > Signed-off-by: Tomasz Figa <t.figa@xxxxxxxxxxx> > > I realize of_clk_init() now handles better clock provider dependencies, > nevertheless do we really need all this churn ? > I have sent v2 of the patchset while retaining the platform driver infrastructure. Awaiting your review comments on that. > -- > Thanks, > Sylwester > Thanks, -- Tushar Behera -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
