On Thu, Mar 25, 2021 at 09:55:07PM -0400, Alistair Francis wrote: > Initial support for the Silergy SY7636A Power Management chip > and regulator. > > Signed-off-by: Alistair Francis <alistair@xxxxxxxxxxxxx> > --- > v3: > - No change > v2: > - N/A > > .../bindings/mfd/silergy,sy7636a.yaml | 63 +++++++++++++++++++ > 1 file changed, 63 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/silergy,sy7636a.yaml > > diff --git a/Documentation/devicetree/bindings/mfd/silergy,sy7636a.yaml b/Documentation/devicetree/bindings/mfd/silergy,sy7636a.yaml > new file mode 100644 > index 000000000000..f260a8eae226 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/silergy,sy7636a.yaml > @@ -0,0 +1,63 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mfd/silergy,sy7636a.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: silergy sy7636a PMIC > + > +maintainers: > + - Alistair Francis <alistair@xxxxxxxxxxxxx> > + > +properties: > + compatible: > + const: silergy,sy7636a > + > + reg: > + maxItems: 1 > + > + '#thermal-sensor-cells': > + const: 0 > + > + regulators: > + type: object > + $ref: /schemas/regulator/regulator.yaml# This isn't right as the actual regulators are child nodes of 'regulators'. So you need another level defined here. This node should also have 'additionalProperties: false' which will highlight the errors here. > + > + properties: > + compatible: > + const: silergy,sy7636a-regulator > + > + regulator-name: > + pattern: "vcom" Not a pattern. Use 'const'. > + > +required: > + - compatible > + - reg > + - '#thermal-sensor-cells' > + > +additionalProperties: false > + > +examples: > + - | > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + sy7636a@62 { pmic@62 > + compatible = "silergy,sy7636a"; > + reg = <0x62>; > + status = "okay"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_epdpmic>; > + #thermal-sensor-cells = <0>; > + > + regulators { > + compatible = "silergy,sy7636a-regulator"; > + reg_epdpmic: vcom { > + regulator-name = "vcom"; > + regulator-boot-on; > + }; > + }; > + }; > + }; > +... > -- > 2.31.0 >
