On Mon, Mar 22, 2021 at 07:50:31PM +0100, Daniel Mack wrote: > This adds documentation for a new ILI9163 based, SPI connected display. > > Signed-off-by: Daniel Mack <daniel@xxxxxxxxxx> > --- > .../bindings/display/ilitek,ili9163.yaml | 70 +++++++++++++++++++ As this is panel chip, put it in panel/. > 1 file changed, 70 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/ilitek,ili9163.yaml > > diff --git a/Documentation/devicetree/bindings/display/ilitek,ili9163.yaml b/Documentation/devicetree/bindings/display/ilitek,ili9163.yaml > new file mode 100644 > index 0000000000000..b98c6b871b790 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/ilitek,ili9163.yaml > @@ -0,0 +1,70 @@ > +# SPDX-License-Identifier: GPL-2.0-only For new bindings: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/ilitek,ili9163.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Ilitek ILI9163 display panels device tree bindings > + > +maintainers: > + - Daniel Mack <daniel@xxxxxxxxxx> > + > +description: > + This binding is for display panels using an Ilitek ILI9163 controller in SPI > + mode. > + > +allOf: > + - $ref: panel/panel-common.yaml# > + > +properties: > + compatible: > + items: > + - enum: > + - newhaven,1.8-128160EF > + - ilitek,ili9163 > + - const: ilitek,ili9163 This says '"ilitek,ili9163", "ilitek,ili9163"' is valid. > + > + spi-max-frequency: > + maximum: 32000000 > + > + dc-gpios: > + maxItems: 1 > + description: Display data/command selection (D/CX) > + > + backlight: true > + reg: true > + reset-gpios: true > + rotation: true > + > +required: > + - compatible > + - reg > + - dc-gpios > + - reset-gpios > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/gpio/gpio.h> > + > + backlight: backlight { > + compatible = "gpio-backlight"; > + gpios = <&gpio 22 GPIO_ACTIVE_HIGH>; > + }; > + spi { > + #address-cells = <1>; > + #size-cells = <0>; > + > + display@0{ space ^ > + compatible = "waveshare,rpi-lcd-35", "ilitek,ili9486"; ?? > + reg = <0>; > + spi-max-frequency = <32000000>; > + dc-gpios = <&gpio0 24 GPIO_ACTIVE_HIGH>; > + reset-gpios = <&gpio0 25 GPIO_ACTIVE_HIGH>; > + rotation = <180>; > + backlight = <&backlight>; > + }; > + }; > + > +... > -- > 2.29.2 >