On Wed, 24 Mar 2021 14:07:06 -0600 Rob Herring <robh@xxxxxxxxxx> wrote: > On Wed, Mar 24, 2021 at 11:35:55AM +0100, Marek Behún wrote: > > In order to be able to define a property describing an array of PHY > > interface modes, we need to change the current scalar > > `phy-connection-type`, which lists the possible PHY interface modes, to > > an array of length 1 (otherwise we would need to define the same list at > > two different places). > > > > Moreover Rob Herring says that we cannot reuse the values of a property; > > we need to $ref a type. > > > > Move the definition of possible PHY interface modes from the > > `phy-connection-type` property to an array type definition > > `phy-connection-type-array`, and simply reference this type in the > > original property. > > Why not just extend phy-connection-type to support more than 1 entry? Hmm, that would be even better, although it would complicate the Russell's marvell10g patches a little if we want the code to be backward compatible with older device trees. I will look into this. Marek
