On Mon, 22 Mar 2021 19:21:39 +0100, Julia Lawall wrote: > From: kernel test robot <lkp@xxxxxxxxx> > > Function "for_each_child_of_node" should have of_node_put() before goto. > > Generated by: scripts/coccinelle/iterators/for_each_child.cocci > > Fixes: 82c2d81361ec ("coccinelle: iterators: Add for_each_child.cocci script") > CC: Sumera Priyadarsini <sylphrenadin@xxxxxxxxx> > Reported-by: kernel test robot <lkp@xxxxxxxxx> > Signed-off-by: kernel test robot <lkp@xxxxxxxxx> > Signed-off-by: Julia Lawall <julia.lawall@xxxxxxxx> > --- > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master > head: 812da4d39463a060738008a46cfc9f775e4bfcf6 > commit: 82c2d81361ecd142a54e84a9da1e287113314a4f coccinelle: iterators: Add for_each_child.cocci script > :::::: branch date: 13 hours ago > :::::: commit date: 5 months ago > > overlay.c | 1 + > 1 file changed, 1 insertion(+) > > --- a/drivers/of/overlay.c > +++ b/drivers/of/overlay.c > @@ -796,6 +796,7 @@ static int init_overlay_changeset(struct > if (!fragment->target) { > of_node_put(fragment->overlay); > ret = -EINVAL; > + of_node_put(node); > goto err_free_fragments; > } > > > Applied, thanks!