On Wed, Mar 24, 2021 at 03:48:35PM +0530, Roja Rani Yarubandi wrote: > This reverts commit 048eb908a1f2 ("soc: qcom-geni-se: Add interconnect > support to fix earlycon crash") > > ICC core and platforms drivers supports sync_state feature, which > ensures that the default ICC BW votes from the bootloader is not > removed until all it's consumers are probes. > > The proxy votes were needed in case other QUP child drivers > I2C, SPI probes before UART, they can turn off the QUP-CORE clock > which is shared resources for all QUP driver, this causes unclocked > access to HW from earlycon. > > Given above support from ICC there is no longer need to maintain > proxy votes on QUP-CORE ICC node from QUP wrapper driver for early > console usecase, the default votes won't be removed until real > console is probed. > > Cc: stable@xxxxxxxxxxxxxxx > Fixes: 266cd33b5913 ("interconnect: qcom: Ensure that the floor bandwidth value is enforced") > Fixes: 7d3b0b0d8184 ("interconnect: qcom: Use icc_sync_state") Neither of these commits introduced an issue that is fixed by this patch, rather this patch relies on these commits to not (re-)introduce an issue. I don't think a 'Fixes' tag is needed for this patch. If anything it fixes the same issue as commit 048eb908a1f2 ("soc: qcom-geni-se: Add interconnect support to fix earlycon crash"), which doesn't have such a tag.