Hi Geert, On Thu, Jul 10, 2014 at 2:48 PM, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > Hi Harini, > > On Thu, Jul 10, 2014 at 10:50 AM, Harini Katakam <harinik@xxxxxxxxxx> wrote: >> + master->flags = SPI_MASTER_QUAD_MODE; > > SPI_MASTER_QUAD_MODE is not one of the SPI_MASTER_* defines > in include/linux/spi/spi.h? > I'm sorry about that. That flag is unused - will remove this statement. >> + master->mode_bits = SPI_CPOL | SPI_CPHA | SPI_RX_DUAL | SPI_RX_QUAD | >> + SPI_TX_DUAL | SPI_TX_QUAD; > > Your driver advertises Dual/Quad SPI Transfer capabilities, but it doesn't > check spi_transfer.[tr]x_nbits? How can it determine when to enable Dual/Quad? > Here the driver is just giving information that the controller support it. The MTD layer enables dual/quad based on what the flash supports; quad being the first priority I understand that the spi core reads rx, tx-bus-width property and master support flags and performs the necessary checks. Regards, Harini -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
