On Wed, Mar 24, 2021 at 10:02:53AM +0100, Michal Simek wrote: > > > On 3/24/21 9:49 AM, Greg Kroah-Hartman wrote: > > On Wed, Mar 24, 2021 at 09:29:12AM +0100, Michal Simek wrote: > >> On 3/23/21 2:42 PM, Greg Kroah-Hartman wrote: > >>> On Wed, Mar 17, 2021 at 01:55:16PM +0530, Sai Krishna Potthuri wrote: > >>>> Adding pinctrl driver for Xilinx ZynqMP platform. > >>>> This driver queries pin information from firmware and registers > >>>> pin control accordingly. > >>>> > >>>> Signed-off-by: Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@xxxxxxxxxx> > >>>> --- > >>>> drivers/pinctrl/Kconfig | 13 + > >>>> drivers/pinctrl/Makefile | 1 + > >>>> drivers/pinctrl/pinctrl-zynqmp.c | 1030 ++++++++++++++++++++++++++++++ > >>>> 3 files changed, 1044 insertions(+) > >>>> create mode 100644 drivers/pinctrl/pinctrl-zynqmp.c > >>>> > >>>> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig > >>>> index 815095326e2d..25d3c7208975 100644 > >>>> --- a/drivers/pinctrl/Kconfig > >>>> +++ b/drivers/pinctrl/Kconfig > >>>> @@ -341,6 +341,19 @@ config PINCTRL_ZYNQ > >>>> help > >>>> This selects the pinctrl driver for Xilinx Zynq. > >>>> > >>>> +config PINCTRL_ZYNQMP > >>>> + bool "Pinctrl driver for Xilinx ZynqMP" > >>> > >>> Please make this work as a module. > >> > >> The most of pinctrl drivers are builtin modules now which is not excuse > >> it is just fact. > >> $ git grep module_pla drivers/pinctrl/ | wc -l > >> 40 > >> $ git grep builtin_pla drivers/pinctrl/ | wc -l > >> 64 > > > > For new ones, we can do better, don't make us have to go back and fix > > this up later. > > As I said not a big deal. If this is the way to go then I these rules > should be followed which is not what it is happening based on 3 latest > pinctrl drivers below. I do not disagree, but I point out issues when I see them, you got unlucky :)
