On 19/03/2021 12:24, Robert Foss wrote: > On Fri, 19 Mar 2021 at 11:49, Robert Foss <robert.foss@xxxxxxxxxx> wrote: >> >> sm8350 has 29 thermal sensors split across two tsens controllers. Add >> the thermal zones to expose them and wireup the cpus to throttle their >> frequencies on crossing passive temperature thresholds. >> >> Signed-off-by: Robert Foss <robert.foss@xxxxxxxxxx> >> --- [ ... ] >> + }; >> + >> + // TODO: What is the NSP subsystem? > > This comment should not have been included, will remove in v2 Please trim when replying to a large patch file. [ ... ] >> + trips { >> + nspss1_alert0: trip-point0 { >> + temperature = <90000>; >> + hysteresis = <1000>; >> + type = "hot"; >> + }; >> + }; >> + }; >> + >> + // TODO: What is the NSP subsystem? > > This comment should not have been included, will remove in v2 [ ... ] >> + trips { >> + nspss2_alert0: trip-point0 { >> + temperature = <90000>; >> + hysteresis = <1000>; >> + type = "hot"; >> + }; >> + }; >> + }; >> + >> + // TODO: What is the NSP subsystem? > > This comment should not have been included, will remove in v2 > [ ... ] -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog