Re: [PATCH 7/7] arm64: dts: mt8173: Drop compatible for mt6397

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Matthias,

Thank you for your patch.

Missatge de l'adreça <matthias.bgg@xxxxxxxxxx> del dia dv., 12 de març
2021 a les 15:57:
>
> From: Matthias Brugger <mbrugger@xxxxxxxx>
>
> The regulator framework does not need compatible, it's actually
> superfluous. Drop it from the DT.
>
> Signed-off-by: Matthias Brugger <mbrugger@xxxxxxxx>
>
> Series-to: lee.jones@xxxxxxxxxx
> Series-to: robh+dt@xxxxxxxxxx
> Series-to: matthias.bgg@xxxxxxxxx
> Series-to: lgirdwood@xxxxxxxxx
> Series-to: broonie@xxxxxxxxxx
> Series-cc: devicetree@xxxxxxxxxxxxxxx
> Series-cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> Series-cc: linux-mediatek@xxxxxxxxxxxxxxxxxxx
> Series-cc: linux-kernel@xxxxxxxxxxxxxxx
> ---
>  arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 4 +---
>  arch/arm64/boot/dts/mediatek/mt8173-evb.dts  | 4 +---
>  2 files changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> index 21452c51a20a8..db06a986f763e 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> @@ -916,9 +916,7 @@ pio6397: pinctrl {
>                         #gpio-cells = <2>;
>                 };
>
> -               regulator: mt6397regulator {
> -                       compatible = "mediatek,mt6397-regulator";
> -
> +               mt6397regulator {

The same happens here, it is not checked because the mt6397 is not in
YAML format yet, but once we do this it'll trigger an error as the
node name should be 'regulators'


>                         mt6397_vpca15_reg: buck_vpca15 {
>                                 regulator-compatible = "buck_vpca15";
>                                 regulator-name = "vpca15";
> diff --git a/arch/arm64/boot/dts/mediatek/mt8173-evb.dts b/arch/arm64/boot/dts/mediatek/mt8173-evb.dts
> index 6dffada2e66b4..c3f2a85d55fe7 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8173-evb.dts
> +++ b/arch/arm64/boot/dts/mediatek/mt8173-evb.dts
> @@ -303,9 +303,7 @@ pmic: mt6397 {
>                 interrupt-controller;
>                 #interrupt-cells = <2>;
>
> -               mt6397regulator: mt6397regulator {
> -                       compatible = "mediatek,mt6397-regulator";
> -
> +               mt6397regulator {
>                         mt6397_vpca15_reg: buck_vpca15 {
>                                 regulator-compatible = "buck_vpca15";
>                                 regulator-name = "vpca15";
> --
> 2.30.1
>
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/linux-mediatek




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux