Hi,
Can you please check the comments below so we don't have to
add duplicate data just to remove it later on.
* Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx> [140708 11:43]:
> +
> +static struct omap_hwmod_irq_info dra7xx_gmac_irqs[] = {
> + { .name = "c0_rx_thresh_pend", .irq = 50 + DRA7XX_IRQ_GIC_START, },
> + { .name = "c0_rx_pend", .irq = 51 + DRA7XX_IRQ_GIC_START, },
> + { .name = "c0_tx_pend", .irq = 52 + DRA7XX_IRQ_GIC_START, },
> + { .name = "c0_misc_pend", .irq = 53 + DRA7XX_IRQ_GIC_START, },
> + { .irq = -1 },
> +};
Why do we need the interrupts here? They should be coming
from the .dts files? Is this numbering with or without
the crossbar?
> +static struct omap_hwmod_addr_space dra7xx_gmac_addr_space[] = {
> + /* cpsw ss */
> + {
> + .pa_start = 0x48484000,
> + .pa_end = 0x48484000 + SZ_2K - 1,
> + },
> + /* cpsw wr */
> + {
> + .pa_start = 0x48485200,
> + .pa_end = 0x48485200 + SZ_256 - 1,
> + .flags = ADDR_TYPE_RT,
> + },
> + { }
> +};
Also for the IO range, this should be coming from the .dts
files now?
> +static struct omap_hwmod_addr_space dra7xx_mdio_addr_space[] = {
> + {
> + .pa_start = 0x48485000,
> + .pa_end = 0x48485000 + SZ_256 - 1,
> + },
> + { }
> +};
Here too?
Regards,
Tony
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
