Hi Linus, On Sun, Mar 14, 2021 at 9:00 AM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote: > > This converts the BCM4329 family bindings to YAML schema, and > extends and fixes the bindings like this: > > - Name the bindings after the first chip (BCM4329) since > wildcards like 43xx are nowadays frowned upon by the DT > binding reviewers. We call this the "BCM4329 family" > - Add compatible strings for all the variants that seem to > exist in the wild. (Derived from firmware listings.) > - Add required reg property (SDIO function number) > - Add reset-gpios property (some systems wire this to a GPIO > line). > - I have only listed Arend as maintainer for now, volunteers > can be added. > > Cc: Arend van Spriel <aspriel@xxxxxxxxx> > Cc: Franky Lin <franky.lin@xxxxxxxxxxxx> > Cc: Hante Meuleman <hante.meuleman@xxxxxxxxxxxx> > Cc: Chi-hsien Lin <chi-hsien.lin@xxxxxxxxxxxx> > Cc: Wright Feng <wright.feng@xxxxxxxxxxxx> > Cc: Chung-hsien Hsu <chung-hsien.hsu@xxxxxxxxxxxx> > Cc: brcm80211-dev-list.pdl@xxxxxxxxxxxx > Cc: SHA-cyfmac-dev-list@xxxxxxxxxxxx > Cc: linux-mmc@xxxxxxxxxxxxxxx > Cc: devicetree@xxxxxxxxxxxxxxx > Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx> > --- > .../net/wireless/brcm,bcm4329-fmac.yaml | 98 +++++++++++++++++++ > .../net/wireless/brcm,bcm43xx-fmac.txt | 38 ------- > 2 files changed, 98 insertions(+), 38 deletions(-) > create mode 100644 Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml > delete mode 100644 Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt > > diff --git a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml > new file mode 100644 > index 000000000000..d172ee486cf6 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml > @@ -0,0 +1,98 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/wireless/brcm,bcm4329-fmac.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Broadcom BCM4329 family fullmac wireless SDIO devices > + > +maintainers: > + - Arend van Spriel <arend@xxxxxxxxxxxx> > + > +description: > + The Broadcom Single chip MAC part for the BCM4329 family and > + later Cypress chips in the same family named CYW4373 and similar. > + These chips also have a Bluetooth portion described in a separate > + binding. > + > +properties: > + compatible: > + items: > + - enum: > + - brcm,bcm43143-fmac > + - brcm,bcm4341b0-fmac > + - brcm,bcm4341b4-fmac > + - brcm,bcm4341b5-fmac > + - brcm,bcm4329-fmac > + - brcm,bcm4330-fmac > + - brcm,bcm4334-fmac > + - brcm,bcm43340-fmac > + - brcm,bcm4335-fmac > + - brcm,bcm43362-fmac > + - brcm,bcm4339-fmac > + - brcm,bcm43430a0-fmac > + - brcm,bcm43430a1-fmac > + - brcm,bcm43455-fmac > + - brcm,bcm43456-fmac > + - brcm,bcm4354-fmac > + - brcm,bcm4356-fmac > + - brcm,bcm4359-fmac > + - cypress,cyw4373-fmac > + - cypress,cyw43012-fmac I don't know if this is necessary for SDIO, but should the non-4329 compatibles have the 4329 compatible as an alternative? Thanks, -- Julian Calaby Email: julian.calaby@xxxxxxxxx Profile: http://www.google.com/profiles/julian.calaby/