Quoting Sibi Sankar (2021-03-08 21:51:50)
> Add PDC Global reset signals for Wireless Processor Subsystem (WPSS)
> on SC7280 SoCs.
>
> Signed-off-by: Sibi Sankar <sibis@xxxxxxxxxxxxxx>
> ---
> drivers/reset/reset-qcom-pdc.c | 62 ++++++++++++++++++++++++++++++++++--------
> 1 file changed, 51 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/reset/reset-qcom-pdc.c b/drivers/reset/reset-qcom-pdc.c
> index ab74bccd4a5b..bb7113ae6232 100644
> --- a/drivers/reset/reset-qcom-pdc.c
> +++ b/drivers/reset/reset-qcom-pdc.c
> @@ -11,18 +11,26 @@
>
> #include <dt-bindings/reset/qcom,sdm845-pdc.h>
>
> -#define RPMH_PDC_SYNC_RESET 0x100
> +#define RPMH_SDM845_PDC_SYNC_RESET 0x100
> +#define RPMH_SC7280_PDC_SYNC_RESET 0x1000
>
> struct qcom_pdc_reset_map {
> u8 bit;
> };
>
> +struct qcom_pdc_reset_desc {
> + const struct qcom_pdc_reset_map *resets;
> + unsigned int offset;
> + size_t num_resets;
Please put num_resets next to resets and move offset before or after the
block. That way we know that resets and num_resets are related because
they're right next to each other.
> +};
> +
> struct qcom_pdc_reset_data {
> struct reset_controller_dev rcdev;
> struct regmap *regmap;
> + const struct qcom_pdc_reset_desc *desc;
> };
>
> -static const struct regmap_config sdm845_pdc_regmap_config = {
> +static const struct regmap_config pdc_regmap_config = {
> .name = "pdc-reset",
> .reg_bits = 32,
> .reg_stride = 4,
