On Fri, Mar 12, 2021 at 7:42 AM <Conor.Dooley@xxxxxxxxxxxxx> wrote: > > On 11/03/2021 17:43, Rob Herring wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > > > On Thu, Mar 11, 2021 at 11:34:56AM +0000, conor.dooley@xxxxxxxxxxxxx wrote: > >> From: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> > >> > >> Add device tree bindings for the MSS system controller on > >> the Microchip PolarFire SoC. > >> > >> Signed-off-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> > >> --- > >> ...icrochip,polarfire-soc-sys-controller.yaml | 36 +++++++++++++++++++ > >> 1 file changed, 36 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/soc/microchip/microchip,polarfire-soc-sys-controller.yaml > >> > >> diff --git a/Documentation/devicetree/bindings/soc/microchip/microchip,polarfire-soc-sys-controller.yaml b/Documentation/devicetree/bindings/soc/microchip/microchip,polarfire-soc-sys-controller.yaml > >> new file mode 100644 > >> index 000000000000..222557f96a13 > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/soc/microchip/microchip,polarfire-soc-sys-controller.yaml > >> @@ -0,0 +1,36 @@ > >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > >> +%YAML 1.2 > >> +--- > >> +$id: "http://devicetree.org/schemas/soc/microchip/microchip,polarfire-soc-sys-controller.yaml#"; > >> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"; > >> + > >> +title: Microchip PolarFire SoC (MPFS) MSS (microprocessor subsystem) system controller > >> + > >> +maintainers: > >> + - Conor Dooley <conor.dooley@xxxxxxxxxxxxx> > >> + > >> +description: | > >> + The PolarFire SoC system controller can be accessed as a mailbox device. > >> + This document describes the bindings for that device. > >> + > >> + > >> +properties: > >> + > >> + allOf: > >> + - $ref: /schemas/mbox/mbox-consumer.yaml#properties > > This defines a DT property 'allOf'. This would need to be at the top > > level with 'properties' dropped. However, you generally don't want to > > include consumer schemas. You need to define 'mboxes' property here > > because you need to define how many and what they are if more than 1. > > In a previous version i was defining it like the below, but you didnt like the redefinition of the common property. > Is there something in between the two that you are looking for? > > mboxes: > maxItems: 1 > description: | > phandle and index of the mailbox controller device node. You don't need a description that applies to every 'mboxes' property. You need either for 1 entry: mboxes: maxItems: 1 Or for multiple entries: mboxes: items: - description: What the 1st entry is for - description: What the 2nd entry is for ... Same thing applies to all common properties where the binding defines how many entries (reg, interrupts, clocks, power-domains, etc.). Rob
