Hi Robert, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on clk/clk-next] [also build test WARNING on v5.12-rc2 next-20210311] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Robert-Hancock/Si5341-driver-updates/20210312-062821 base: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next config: arm64-randconfig-r034-20210312 (attached as .config) compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 7b153b43d3a14d76975039408c4b922beb576735) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install arm64 cross compiling tool for clang build # apt-get install binutils-aarch64-linux-gnu # https://github.com/0day-ci/linux/commit/636016363158ea8e30592ff4974f344ca0043f82 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Robert-Hancock/Si5341-driver-updates/20210312-062821 git checkout 636016363158ea8e30592ff4974f344ca0043f82 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>): >> drivers/clk/clk-si5341.c:1710:5: warning: no previous prototype for function 'si5341_remove' [-Wmissing-prototypes] int si5341_remove(struct i2c_client *client) ^ drivers/clk/clk-si5341.c:1710:1: note: declare 'static' if the function is not intended to be used outside of this translation unit int si5341_remove(struct i2c_client *client) ^ static 1 warning generated. vim +/si5341_remove +1710 drivers/clk/clk-si5341.c 1709 > 1710 int si5341_remove(struct i2c_client *client) 1711 { 1712 struct clk_si5341 *data = i2c_get_clientdata(client); 1713 int i; 1714 1715 for (i = 0; i < SI5341_MAX_NUM_OUTPUTS; ++i) { 1716 if (data->clk[i].vdd_reg) 1717 regulator_disable(data->clk[i].vdd_reg); 1718 } 1719 1720 return 0; 1721 } 1722 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip