On 11/03/2021 10:14, Arnd Bergmann wrote: > On Thu, Mar 11, 2021 at 8:08 AM Krzysztof Kozlowski > <krzysztof.kozlowski@xxxxxxxxxxxxx> wrote: >> On 10/03/2021 17:42, Arnd Bergmann wrote: >>> On Wed, Mar 10, 2021 at 4:54 PM Krzysztof Kozlowski >>> <krzysztof.kozlowski@xxxxxxxxxxxxx> wrote: >>>> On 10/03/2021 16:47, Krzysztof Kozlowski wrote: >>>>> This edac Altera driver is very weird... it uses the same compatible >>>>> differently depending whether this is 32-bit or 64-bit (e.g. Stratix >>>>> 10)! On ARMv7 the compatible means for example one IRQ... On ARMv8, we >>>>> have two. It's quite a new code (2019 from Intel), not some ancient >>>>> legacy, so it should never have been accepted... >>>> >>>> Oh, it's not that horrible as it sounds. They actually have different >>>> compatibles for edac driver with these differences (e.g. in interrupts). >>>> They just do not use them and instead check for the basic (common?) >>>> compatible and architecture... Anyway without testing I am not the >>>> person to fix the edac driver. >>> >>> Ok, This should be fixed properly as you describe, but as a quick hack >>> it wouldn't be hard to just change the #ifdef to check for CONFIG_64BIT >>> instead of CONFIG_ARCH_STRATIX10 during the rename of the config >>> symbol. >> >> This would work. The trouble with renaming ARCH_SOCFPGA into >> ARCH_INTEL_SOCFPGA is that still SOCFPGA will appear in many other >> Kconfig symbols or even directory paths. >> >> Let me use ARCH_INTEL_SOCFPGA for 64bit here and renaming of 32bit a >> little bit later. > > Maybe you can introduce a hidden 'ARCH_INTEL_SOCFPGA' option first > and select that from both the 32-bit and the 64-bit platforms in the first step. > > That should decouple the cleanups, so you can change the drivers to > (only) 'depends on ARCH_INTEL_SOCFPGA' before removing the other > names. Sure, let me try that. I have a v3 almost ready. Best regards, Krzysztof
