On Sun, Mar 7, 2021 at 3:08 AM Álvaro Fernández Rojas <noltari@xxxxxxxxx> wrote: > > Hi Rob, > > El 06/03/2021 a las 22:17, Rob Herring escribió: > > On Thu, Feb 25, 2021 at 08:41:59PM +0100, Álvaro Fernández Rojas wrote: > >> Add missing timer reset definitions for BCM63268. > >> > >> Signed-off-by: Álvaro Fernández Rojas <noltari@xxxxxxxxx> > >> --- > >> include/dt-bindings/reset/bcm63268-reset.h | 4 ++++ > >> 1 file changed, 4 insertions(+) > >> > >> diff --git a/include/dt-bindings/reset/bcm63268-reset.h b/include/dt-bindings/reset/bcm63268-reset.h > >> index 6a6403a4c2d5..d87a7882782a 100644 > >> --- a/include/dt-bindings/reset/bcm63268-reset.h > >> +++ b/include/dt-bindings/reset/bcm63268-reset.h > >> @@ -23,4 +23,8 @@ > >> #define BCM63268_RST_PCIE_HARD 17 > >> #define BCM63268_RST_GPHY 18 > >> > >> +#define BCM63268_TRST_SW 29 > >> +#define BCM63268_TRST_HW 30 > >> +#define BCM63268_TRST_POR 31 > > > > Numbering should be local to the provider, so shouldn't this be 0-2? > > Unless these numbers correspond to something in the h/w (bit positions > > for example). > > Numbering corresponds to bit positions in the HW: Okay, good. Acked-by: Rob Herring <robh@xxxxxxxxxx>
