Hello Lee, On Mon, 2021-03-08 at 13:36 +0000, Lee Jones wrote: > On Thu, 11 Feb 2021, Matti Vaittinen wrote: > > > Add core support for ROHM BD9576MUF and BD9573MUF PMICs which are > > mainly used to power the R-Car series processors. > > > > Signed-off-by: Matti Vaittinen <matti.vaittinen@xxxxxxxxxxxxxxxxx> > > --- > > Changes: > > - Comments fixed based on suggestions from Lee > > - Name of regulator cell changed as suggested by Lee > > - Renamed MFD cell variables for better readability > > - Aligned header definitions for better readability > > > > drivers/mfd/Kconfig | 11 ++++ > > drivers/mfd/Makefile | 1 + > > drivers/mfd/rohm-bd9576.c | 109 > > +++++++++++++++++++++++++++++++ > > include/linux/mfd/rohm-bd957x.h | 59 +++++++++++++++++ > > include/linux/mfd/rohm-generic.h | 2 + > > 5 files changed, 182 insertions(+) > > create mode 100644 drivers/mfd/rohm-bd9576.c > > create mode 100644 include/linux/mfd/rohm-bd957x.h > > > > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > > index bdfce7b15621..53c7c96283bd 100644 > > --- a/drivers/mfd/Kconfig > > +++ b/drivers/mfd/Kconfig > > @@ -1998,6 +1998,17 @@ config MFD_ROHM_BD71828 > > Also included is a Coulomb counter, a real-time clock (RTC), > > and > > a 32.768 kHz clock gate. > > > > +config MFD_ROHM_BD957XMUF > > + tristate "ROHM BD9576MUF and BD9573MUF Power Management ICs" > > + depends on I2C=y > > + depends on OF > > + select REGMAP_I2C > > + select MFD_CORE > > + help > > + Select this option to get support for the ROHM BD9576MUF and > > + BD9573MUF Power Management ICs. BD9576 and BD9573 are > > primarily > > + designed to be used to power R-Car series processors. > > + > > config MFD_STM32_LPTIMER > > tristate "Support for STM32 Low-Power Timer" > > depends on (ARCH_STM32 && OF) || COMPILE_TEST > > diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile > > index 14fdb188af02..e58fae024bb2 100644 > > --- a/drivers/mfd/Makefile > > +++ b/drivers/mfd/Makefile > > @@ -262,6 +262,7 @@ obj-$(CONFIG_RAVE_SP_CORE) += rave-sp.o > > obj-$(CONFIG_MFD_ROHM_BD70528) += rohm-bd70528.o > > obj-$(CONFIG_MFD_ROHM_BD71828) += rohm-bd71828.o > > obj-$(CONFIG_MFD_ROHM_BD718XX) += rohm-bd718x7.o > > +obj-$(CONFIG_MFD_ROHM_BD957XMUF) += rohm-bd9576.o > > obj-$(CONFIG_MFD_STMFX) += stmfx.o > > obj-$(CONFIG_MFD_KHADAS_MCU) += khadas-mcu.o > > > > diff --git a/drivers/mfd/rohm-bd9576.c b/drivers/mfd/rohm-bd9576.c > > new file mode 100644 > > index 000000000000..efd439677c9e > > --- /dev/null > > +++ b/drivers/mfd/rohm-bd9576.c > > @@ -0,0 +1,109 @@ > > +// SPDX-License-Identifier: GPL-2.0-or-later > > +/* > > + * Copyright (C) 2020 ROHM Semiconductors > > If you get a chance, could you please update these? I'll respin the series as I'll add designated initializers for MFD regulator array cell as you suggested. So I'll update this at the same time. > > > + * ROHM BD9576MUF and BD9573MUF PMIC driver > > + */ > > For my own reference (apply this as-is to your sign-off block): > > Acked-for-MFD-by: Lee Jones <lee.jones@xxxxxxxxxx> >
