On Fri, Feb 12, 2021 at 02:22:47PM -0800, mgross@xxxxxxxxxxxxxxx wrote: > From: Seamus Kelly <seamus.kelly@xxxxxxxxx> Please make the subjects consistent. > > Add device tree bindings for the xLink IPC driver which enables xLink to > control and communicate with the VPU IP present on the Intel Keem Bay > SoC. > > Cc: Rob Herring <robh+dt@xxxxxxxxxx> > Cc: devicetree@xxxxxxxxxxxxxxx > Reviewed-by: Mark Gross <mgross@xxxxxxxxxxxxxxx> > Signed-off-by: Mark Gross <mgross@xxxxxxxxxxxxxxx> > Signed-off-by: Seamus Kelly <seamus.kelly@xxxxxxxxx> > --- > .../misc/intel,keembay-xlink-ipc.yaml | 51 +++++++++++++++++++ > 1 file changed, 51 insertions(+) > create mode 100644 Documentation/devicetree/bindings/misc/intel,keembay-xlink-ipc.yaml > > diff --git a/Documentation/devicetree/bindings/misc/intel,keembay-xlink-ipc.yaml b/Documentation/devicetree/bindings/misc/intel,keembay-xlink-ipc.yaml > new file mode 100644 > index 000000000000..70a3061d024d > --- /dev/null > +++ b/Documentation/devicetree/bindings/misc/intel,keembay-xlink-ipc.yaml > @@ -0,0 +1,51 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +# Copyright (c) Intel Corporation. All rights reserved. > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/misc/intel,keembay-xlink-ipc.yaml#"; > +$schema: "http://devicetree.org/meta-schemas/core.yaml#"; > + > +title: Intel Keem Bay xlink IPC > + > +maintainers: > + - Kelly Seamus <seamus.kelly@xxxxxxxxx> Name doesn't match the author. > + > +description: | > + The Keem Bay xlink IPC driver enables the communication/control sub-system > + for internal IPC communications within the Intel Keem Bay SoC. > + > +properties: > + compatible: > + oneOf: > + - items: > + - const: intel,keembay-xlink-ipc Don't need oneOf nor items, just const. > + > + memory-region: > + items: > + - description: reference to the CSS xlink IPC reserved memory region. > + - description: reference to the MSS xlink IPC reserved memory region. > + > + intel,keembay-vpu-ipc-id: > + $ref: "/schemas/types.yaml#/definitions/uint32" > + description: The numeric ID identifying the VPU within the xLink stack. > + > + intel,keembay-vpu-ipc-name: > + $ref: "/schemas/types.yaml#/definitions/string" > + description: User-friendly name for the VPU within the xLink stack. > + > + intel,keembay-vpu-ipc: > + $ref: "/schemas/types.yaml#/definitions/phandle" > + description: reference to the corresponding intel,keembay-vpu-ipc node. Is there more than one? > + > +additionalProperties: False > + > +examples: > + - | > + xlink-ipc { > + compatible = "intel,keembay-xlink-ipc"; > + memory-region = <&css_xlink_reserved>, > + <&mss_xlink_reserved>; > + intel,keembay-vpu-ipc-id = <0x0>; > + intel,keembay-vpu-ipc-name = "vpu-slice-0"; I assume the 0 id is the same as the 0 here? If so, there's not really any reason to put this into DT. You can generate the string if needed in the driver. > + intel,keembay-vpu-ipc = <&vpuipc>; > + }; > -- > 2.17.1 >
