On Fri, Mar 05, 2021 at 10:50:12AM -0800, Doug Anderson wrote: > Hi, > > On Thu, Mar 4, 2021 at 10:04 AM Matthias Kaehlcke <mka@xxxxxxxxxxxx> wrote: > > > > CoachZ rev1 and rev2 are stuffed with a 47k NTC as thermistor for the > > charger temperature which currently isn't supported by the PM6150 ADC > > driver. Disable the charger thermal zone to avoid the use of bogus > > temperature values. > > > > Signed-off-by: Matthias Kaehlcke <mka@xxxxxxxxxxxx> > > --- > > > > arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1.dts | 9 +++++++++ > > arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r2.dts | 9 +++++++++ > > 2 files changed, 18 insertions(+) > > I guess this patch is written with the assumption that eventually > we'll create a "-r3" or "-r4" that has a proper thermistor stuffed but > maybe we're not sure which one? Right now you're disabling it for > both -r1 and -r2+ which is all revisions, so this could go in the > coachz.dtsi file... The proper thermistor should be stuffed in rev3. For some reason there was already a -r3 .dts in my mental model, probably I created one when I started with a downstream version of this series just before you posted your's to bring upstream (mostly) in sync with downstream. I'll add it in v2.
