On Thu, Mar 4, 2021 at 2:25 PM Álvaro Fernández Rojas <noltari@xxxxxxxxx> wrote: > > El 4 mar 2021, a las 13:12, Andy Shevchenko <andy.shevchenko@xxxxxxxxx> escribió: > > On Thu, Mar 4, 2021 at 1:13 PM Álvaro Fernández Rojas <noltari@xxxxxxxxx> wrote: > >>> El 4 mar 2021, a las 11:49, Andy Shevchenko <andy.shevchenko@xxxxxxxxx> escribió: > >>> On Thu, Mar 4, 2021 at 10:57 AM Álvaro Fernández Rojas > >>> <noltari@xxxxxxxxx> wrote: ... > >>>> + BCM6328_MUX_LO_REG, > >>>> + BCM6328_MUX_HI_REG, > >>> > >>>> + BCM6328_MUX_OTHER_REG > >>> > >>> When it's not terminator add a comma, otherwise remove a comma. > > > >> … so you want me to add a comma or not? > > > > Hmm... you tell me! If this is a list which covers all possible cases > > _and_ the last one is the kinda maximum value (aka terminator), then > > comma is not needed, otherwise add it (to me feels like the latter > > should be done here). > > Well… Then it shouldn’t be needed, since this is a list which covers all possible cases and the last one is a terminator. Honestly the name suggests otherwise. And looking into the code there is no guarantee you won't split that _OTHER_ area to something with new compatible hardware. Renaming to BCM6328_MUX_MAX_REG will clear that this is terminator, but it means its value shouldn't be used except as to understand the amount of supported registers of this enumerator. -- With Best Regards, Andy Shevchenko
