Re: [PATCH v4 06/13] phy: cadence: cadence-sierra: Move all reset_control_get*() to a separate function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2021-03-04 at 10:11 +0530, Kishon Vijay Abraham I wrote:
> No functional change. Group devm_reset_control_get() and
> devm_reset_control_get_optional() to a separate function.
> 
> Signed-off-by: Kishon Vijay Abraham I <kishon@xxxxxx>
> ---
>  drivers/phy/cadence/phy-cadence-sierra.c | 36 ++++++++++++++++--------
>  1 file changed, 25 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/phy/cadence/phy-cadence-sierra.c b/drivers/phy/cadence/phy-cadence-sierra.c
> index 7bf1b4c7774a..935f165404e4 100644
> --- a/drivers/phy/cadence/phy-cadence-sierra.c
> +++ b/drivers/phy/cadence/phy-cadence-sierra.c
> @@ -509,6 +509,28 @@ static int cdns_sierra_phy_get_clocks(struct cdns_sierra_phy *sp,
>  	return 0;
>  }
>  
> +static int cdns_sierra_phy_get_resets(struct cdns_sierra_phy *sp,
> +				      struct device *dev)
> +{
> +	struct reset_control *rst;
> +
> +	rst = devm_reset_control_get(dev, "sierra_reset");

Please use
	rst = devm_reset_control_get_exclusive(dev, "sierra_reset");
here ...

> +	if (IS_ERR(rst)) {
> +		dev_err(dev, "failed to get reset\n");
> +		return PTR_ERR(rst);
> +	}
> +	sp->phy_rst = rst;
> +
> +	rst = devm_reset_control_get_optional(dev, "sierra_apb");

... and
	rst = devm_reset_control_get_optional_exclusive(dev, "sierra_apb");	
here (no functional change).

With that,

Reviewed-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>

regards
Philipp



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux