Hi Linus, > El 3 mar 2021, a las 16:29, Linus Walleij <linus.walleij@xxxxxxxxxx> escribió: > > On Wed, Mar 3, 2021 at 3:23 PM Álvaro Fernández Rojas <noltari@xxxxxxxxx> wrote: > >> v3: introduce new files for shared code and add more changes suggested by >> Linus Walleij. Also add a new patch needed for properly parsing gpio-ranges. > > This looks very appetizing, I am ready to merge this once we cut some > slack for DT review (a week or two). > > I'd like to merge it soon so you can start working on the IRQ add-on. > > I'd probably drop the IRQ-related selects from Kconfig > when applying though (no big deal, no need to resend over that). About that, it seems that GPIO_REGMAP should select GPIOLIB_IRQCHIP, since I couldn’t build the kernel due to the following error when I removed the IRQ-related selects: LD vmlinux.o MODPOST vmlinux.symvers MODINFO modules.builtin.modinfo GEN modules.builtin LD .tmp_vmlinux.kallsyms1 mips-linux-gnu-ld: drivers/gpio/gpio-regmap.o: in function `gpio_regmap_register': gpio-regmap.c:(.text+0x704): undefined reference to `gpiochip_irqchip_add_domain' make: *** [Makefile:1197: vmlinux] Error 1 Or maybe we could guard these lines of gpio-regmap.c with #ifdef GPIOLIB_IRQCHIP: https://github.com/torvalds/linux/blob/f69d02e37a85645aa90d18cacfff36dba370f797/drivers/gpio/gpio-regmap.c#L282-L286 > > Yours, > Linus Walleij Best regards, Álvaro.
