Hi Laurent, Thanks for your feedback! > From: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > Sent: 26 February 2021 12:48 > Subject: Re: [PATCH 6/7] arm64: dts: renesas: r8a77965: Add DAB support > > Hi Fabrizio, > > Thank you for the patch. > > On Thu, Feb 25, 2021 at 10:51:46PM +0000, Fabrizio Castro wrote: > > R-Car M3-N (a.k.a. r8a77965) comes with the DAB hardware accelerator. > > This patch adds SoC specific support. > > > > Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@xxxxxxxxxxx> > > --- > > arch/arm64/boot/dts/renesas/r8a77965.dtsi | 12 ++++++++++++ > > 1 file changed, 12 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi > b/arch/arm64/boot/dts/renesas/r8a77965.dtsi > > index 657b20d3533b..b6176fd5b703 100644 > > --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi > > +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi > > @@ -1013,6 +1013,18 @@ ipmmu_vp0: iommu@fe990000 { > > #iommu-cells = <1>; > > }; > > > > + dab: dab@e6730000 { > > + compatible = "renesas,dab-r8a77965", > > + "renesas,rcar-gen3-dab"; > > + reg = <0x00 0xe6730000 0x00 0x120>; > > + interrupts = <GIC_SPI 160 IRQ_TYPE_LEVEL_HIGH>; > > + clocks = <&cpg CPG_MOD 1016>; > > + clock-names = "dab"; > > + power-domains = <&sysc R8A77965_PD_ALWAYS_ON>; > > + resets = <&cpg 1016>; > > Same comments as for r8a77990. I will revise accordingly for v2. Thanks, Fab > > Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > > > + status = "disabled"; > > + }; > > + > > avb: ethernet@e6800000 { > > compatible = "renesas,etheravb-r8a77965", > > "renesas,etheravb-rcar-gen3"; > > -- > Regards, > > Laurent Pinchart