On Mon, Feb 8, 2021 at 11:24 PM Enrico Weigelt, metux IT consult <info@xxxxxxxxx> wrote: > Add support for probing via device tree. (...) > + pdata->gpio_num = of_property_count_elems_of_size(dev->of_node, > + "gpio-regs", > + sizeof(u32)); > + pdata->gpio_reg = devm_kzalloc(dev, sizeof(int)*pdata->gpio_num, > + GFP_KERNEL); > + if (!pdata->gpio_reg) > + goto nomem; I don't know what the idea is with this but register are not normally defined in the DTS files. The registers are determined from the compatible value. > + pdata->gpio_names = devm_kzalloc(dev, sizeof(char*)*pdata->gpio_num, > + GFP_KERNEL); > + if (!pdata->gpio_names) > + goto nomem; (...) > + ret = of_property_read_string_array(dev->of_node, "gpio-line-names", > + pdata->gpio_names, pdata->gpio_num); And this is already handled by the core. Yours, Linus Walleij
