Re: [PATCH v5 2/2] drm/bridge: Introduce LT8912B DSI to HDMI bridge

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Adrien,

I love your patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v5.11 next-20210226]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Adrien-Grassein/Add-support-of-Lontium-lt8912-MIPI-to-HDMI-bridge/20210228-001438
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 3fb6d0e00efc958d01c2f109c8453033a2d96796
config: arm64-randconfig-r025-20210228 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 83bc7815c4235786111aa2abf7193292e4a602f5)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm64 cross compiling tool for clang build
        # apt-get install binutils-aarch64-linux-gnu
        # https://github.com/0day-ci/linux/commit/2d98eba25528e00389795ddc110f56ac6adfde4c
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Adrien-Grassein/Add-support-of-Lontium-lt8912-MIPI-to-HDMI-bridge/20210228-001438
        git checkout 2d98eba25528e00389795ddc110f56ac6adfde4c
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/bridge/lontium-lt8912b.c:461:10: warning: variable 'ret' is uninitialized when used here [-Wuninitialized]
                   return ret;
                          ^~~
   drivers/gpu/drm/bridge/lontium-lt8912b.c:452:9: note: initialize the variable 'ret' to silence this warning
           int ret, num = 0;
                  ^
                   = 0
   1 warning generated.


vim +/ret +461 drivers/gpu/drm/bridge/lontium-lt8912b.c

   448	
   449	static int lt8912_connector_get_modes(struct drm_connector *connector)
   450	{
   451		struct edid *edid;
   452		int ret, num = 0;
   453		struct lt8912 *lt = connector_to_lt8912(connector);
   454		u32 bus_format = MEDIA_BUS_FMT_RGB888_1X24;
   455	
   456		edid = drm_bridge_get_edid(lt->hdmi_port, connector);
   457		if (edid) {
   458			drm_connector_update_edid_property(connector, edid);
   459			num = drm_add_edid_modes(connector, edid);
   460		} else
 > 461			return ret;
   462	
   463		ret = drm_display_info_set_bus_formats(&connector->display_info,
   464						       &bus_format, 1);
   465		if (ret)
   466			num = ret;
   467	
   468		kfree(edid);
   469		return num;
   470	}
   471	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux