Hi,
On 2021-02-25 16:39, Dmitry Baryshkov wrote:
On 24/02/2021 11:33, satya priya wrote:
Correct the REGULATOR_LINEAR_RANGE and n_voltges for
pmic5_hfsmps515 buck.
Signed-off-by: satya priya <skakit@xxxxxxxxxxxxxx>
---
drivers/regulator/qcom-rpmh-regulator.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/regulator/qcom-rpmh-regulator.c
b/drivers/regulator/qcom-rpmh-regulator.c
index 79a554f..36542c3 100644
--- a/drivers/regulator/qcom-rpmh-regulator.c
+++ b/drivers/regulator/qcom-rpmh-regulator.c
@@ -726,8 +726,8 @@ static const struct rpmh_vreg_hw_data
pmic5_ftsmps510 = {
static const struct rpmh_vreg_hw_data pmic5_hfsmps515 = {
.regulator_type = VRM,
.ops = &rpmh_regulator_vrm_ops,
- .voltage_range = REGULATOR_LINEAR_RANGE(2800000, 0, 4, 16000),
- .n_voltages = 5,
+ .voltage_range = REGULATOR_LINEAR_RANGE(320000, 0, 235, 16000),
+ .n_voltages = 236,
I've checked the docs for pm8009, the chip which also uses hfsmps515
regulators. The pdf clearly states that the 'Output voltage operating
range' is from 2.8 V to 2.85 V.
So we'd probably need to define different versions of HFS515 regulator
data (like I had to create for pm8009-1).
The min-max voltages for S1C (PM8350c) regulator are 2190000-2210000uV
for sc7280(kodiak), so we had to modify this buck to support this
regulator.
AFAIK, this struct defines the HW constraints of a regulator, but the
platform specific min-max values can be controlled from DT files. So,
can't we modify it like above instead of adding a new definition? the
new min_uV value (32000) is anyway not exceeding the old value (2800000)
right? please correct me if wrong.
.pmic_mode_map = pmic_mode_map_pmic5_smps,
.of_map_mode = rpmh_regulator_pmic4_smps_of_map_mode,
};
Thanks,
Satya Priya
