Hi Krzysztof, Thanks for your review, I will fix it at next version. On Wed, 2021-02-24 at 15:24 +0100, Krzysztof Wilczyński wrote: > Hi Jianjun, > > [...] > > +/** > > + * mtk_intx_eoi > > + * @data: pointer to chip specific data > > + * > > + * As an emulated level IRQ, its interrupt status will remain > > + * until the corresponding de-assert message is received; hence that > > + * the status can only be cleared when the interrupt has been serviced. > > + */ > [...] > > See my comment about the kernel-doc from the following: > > https://lore.kernel.org/linux-pci/YDZWUGcKet%2FlNWlF@rocinante/ > > [...] > > + if (err) { > > + dev_err(dev, "failed to init PCIe IRQ domain\n"); > > + return err; > > + } > [...] > > Just a nitpick. What about using "initialize" in the above? > > Krzysztof Thanks.
