On Mon, 22 Feb 2021, Cristian Ciocaltea wrote: > On Mon, Feb 22, 2021 at 03:30:16PM +0000, Lee Jones wrote: > > On Mon, 22 Feb 2021, Cristian Ciocaltea wrote: > > > > > On Mon, Feb 22, 2021 at 09:02:47AM +0000, Lee Jones wrote: > > > > On Sun, 21 Feb 2021, Cristian Ciocaltea wrote: > > > > > > > > > Hi Lee, > > > > > > > > > > I have just noticed your mfd-next tag for 5.12 doesn't include the > > > > > support for the ATC260x PMICs. > > > > > > > > > > I assumed the patchset is ready for merging.. Did I miss something? > > > > > > > > The MFD driver needs another review. > > > > > > > > For some reason, this didn't register on my TODO list. > > > > > > You have already tagged v6 with 'Acked-for-MFD-by: Lee Jones > > > <lee.jones@xxxxxxxxxx>': > > > https://lore.kernel.org/lkml/20210125142558.GA4903@dell/ > > > > > > I have submitted v7 to drop the patches that had been already picked up, > > > as previously agreed, but otherwise there are no other changes. > > > > > > That is why I didn't expect another round of review.. > > > > I see what's happened. You forgot to: > > > > "apply this as-is to your sign-off block" > > > > ... as requested, which made me think it needs a subsequent review. > > Sorry, I somehow missed that. Should I resend the patch series? No, no need. It's on my radar now. I'll see to it when v5.12 is out. > If yes, I assume I should also increment the revision number, even > though there are no other changes except the addition of the > indicated tag. When resending, you only have to s/PATCH/RESEND/. > > > > In general, if you don't receive a review within ~2 weeks of posting > > > > (and the merge window is not open), you should consider it lost and > > > > submit a [RESEND]. > > > > Due to the fragility of email reviews, this is still very important. > > Right, thanks for the hint! NP. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
