Hi Ansuel, Thank you for the patch! Yet something to improve: [auto build test ERROR on mtd/mtd/next] [also build test ERROR on mtd/mtd/fixes robh/for-next v5.11 next-20210216] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Ansuel-Smith/Implement-nvmem-support-for-mtd/20210217-035931 base: https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next config: m68k-randconfig-r011-20210216 (attached as .config) compiler: m68k-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/ea1902bc853fa1f1050cc741912709fe5ebbdc41 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Ansuel-Smith/Implement-nvmem-support-for-mtd/20210217-035931 git checkout ea1902bc853fa1f1050cc741912709fe5ebbdc41 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): drivers/mtd/mtdcore.c: In function 'mtd_nvmem_add': >> drivers/mtd/mtdcore.c:546:47: error: 'node' undeclared (first use in this function); did you mean 'inode'? 546 | config.no_of_node = !of_device_is_compatible(node, "nvmem-partitions"); | ^~~~ | inode drivers/mtd/mtdcore.c:546:47: note: each undeclared identifier is reported only once for each function it appears in vim +546 drivers/mtd/mtdcore.c 531 532 static int mtd_nvmem_add(struct mtd_info *mtd) 533 { 534 struct nvmem_config config = {}; 535 536 config.id = -1; 537 config.dev = &mtd->dev; 538 config.name = dev_name(&mtd->dev); 539 config.owner = THIS_MODULE; 540 config.reg_read = mtd_nvmem_reg_read; 541 config.size = mtd->size; 542 config.word_size = 1; 543 config.stride = 1; 544 config.read_only = true; 545 config.root_only = true; > 546 config.no_of_node = !of_device_is_compatible(node, "nvmem-partitions"); 547 config.priv = mtd; 548 549 mtd->nvmem = nvmem_register(&config); 550 if (IS_ERR(mtd->nvmem)) { 551 /* Just ignore if there is no NVMEM support in the kernel */ 552 if (PTR_ERR(mtd->nvmem) == -EOPNOTSUPP) { 553 mtd->nvmem = NULL; 554 } else { 555 dev_err(&mtd->dev, "Failed to register NVMEM device\n"); 556 return PTR_ERR(mtd->nvmem); 557 } 558 } 559 560 return 0; 561 } 562 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip