Hi Rob, On Tue, Feb 2, 2021 at 6:54 PM Rob Herring <robh@xxxxxxxxxx> wrote: > Convert the SPI-NOR binding to DT schema format. Like other memory chips, > the compatible strings are a mess with vendor prefixes not being used > consistently and some compatibles not documented. The resulting schema > passes on 'compatible' checks for most in tree users with the exception > of some oddballs. > > I dropped the 'm25p.*-nonjedec' compatible strings as these don't appear > to be used anywhere. > > Cc: Miquel Raynal <miquel.raynal@xxxxxxxxxxx> > Cc: Richard Weinberger <richard@xxxxxx> > Cc: Vignesh Raghavendra <vigneshr@xxxxxx> > Cc: linux-mtd@xxxxxxxxxxxxxxxxxxx > Signed-off-by: Rob Herring <robh@xxxxxxxxxx> Thanks for your patch! > --- /dev/null > +++ b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml > @@ -0,0 +1,102 @@ > +# SPDX-License-Identifier: GPL-2.0-only > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mtd/jedec,spi-nor.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: SPI NOR flash ST M25Pxx (and similar) serial flash chips > + > +maintainers: > + - Rob Herring <robh@xxxxxxxxxx> > + > +properties: > + compatible: > + oneOf: > + - items: > + - pattern: "^((((micron|spansion|st),)?\ > + (m25p(40|80|16|32|64|128)|\ > + n25q(32b|064|128a11|128a13|256a|512a|164k)))|\ > + atmel,at25df(321a|641|081a)|\ > + everspin,mr25h(10|40|128|256)|\ > + (mxicy|macronix),mx25l(4005a|1606e|6405d|8005|12805d|25635e)|\ > + (mxicy|macronix),mx25u(4033|4035)|\ > + (spansion,)?s25fl(128s|256s1|512s|008k|064k|164k)|\ > + (sst|microchip),sst25vf(016b|032b|040b)|\ > + (sst,)?sst26wf016b|\ > + (sst,)?sst25wf(040b|080)|\ > + winbond,w25x(80|32)|\ > + (winbond,)?w25q(16|32(w|dw)?|64(dw)?|80bl|128(fw)?|256))$" > + - const: jedec,spi-nor > + - items: > + - enum: > + - issi,is25lp016d > + - micron,mt25qu02g > + - mxicy,mx25r1635f > + - mxicy,mx25u6435f > + - mxicy,mx25v8035f > + - spansion,s25sl12801 > + - spansion,s25fs512s > + - const: jedec,spi-nor > + - const: jedec,spi-nor > + description: > + Must also include "jedec,spi-nor" for any SPI NOR flash that can be > + identified by the JEDEC READ ID opcode (0x9F). Is there any value in keeping this paragraph? The schema already requires "jedec,spi-nor". Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
