On Wed, Feb 10, 2021 at 2:40 PM Adam Ford <aford173@xxxxxxxxx> wrote: > > On Wed, Feb 10, 2021 at 2:18 PM Rob Herring <robh@xxxxxxxxxx> wrote: > > > > On Sun, Feb 07, 2021 at 12:51:38PM -0600, Adam Ford wrote: > > > There are two registers which can set the load capacitance for > > > XTAL1 and XTAL2. These are optional registers when using an > > > external crystal. Since XTAL1 and XTAL2 will set to the same value, > > > update the binding to support a single property called > > > xtal-load-femtofarads. > > > > > > Signed-off-by: Adam Ford <aford173@xxxxxxxxx> > > > --- > > > V3: No Change > > > V2: No Change > > > > > > A couple people suggested that I not use the $ref, but without it, > > > the bindings check failed with errors. > > > > > > diff --git a/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml b/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml > > > index 2ac1131fd922..c268debe5b8d 100644 > > > --- a/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml > > > +++ b/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml > > > @@ -59,6 +59,12 @@ properties: > > > minItems: 1 > > > maxItems: 2 > > > > > > + idt,xtal-load-femtofarads: > > > + $ref: /schemas/types.yaml#/definitions/uint32 > > > > Don't need a type with standard unit suffix. > > If I remove that line, the binding check fails. Ah, looks like femtofarads got added to property-units.txt but not the schemas. I'll add it, but fine to leave this as-is for now. Reviewed-by: Rob Herring <robh@xxxxxxxxxx> Rob
